DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
	Tianli Lai <laitianli@tom.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>
Subject: RE: [PATCH] net/dpaa2: fix dpdmux default interface
Date: Tue, 29 Mar 2022 13:45:56 +0000	[thread overview]
Message-ID: <AS8PR04MB9064953A9D8BE478C87D41C1891E9@AS8PR04MB9064.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <bc328cb7-8133-0605-e0f5-e55830d273fc@oss.nxp.com>

BTW, will you please add following fix tags to your commit message

Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
Cc: nipun.gupta@nxp.com

> -----Original Message-----
> From: Hemant Agrawal (OSS) <hemant.agrawal@oss.nxp.com>
> Sent: Tuesday, March 29, 2022 7:01 PM
> To: Tianli Lai <laitianli@tom.com>; dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena (OSS)
> <sachin.saxena@oss.nxp.com>
> Subject: Re: [PATCH] net/dpaa2: fix dpdmux default interface
> Importance: High
> 
> Acked-by:  Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> 
> On 3/30/2022 1:56 AM, Tianli Lai wrote:
> > if dpdmux objects created by restool tools with the argument
> > "--default-if=<if-id-number>", this function would change it to 1
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
> > ---
> >   drivers/net/dpaa2/dpaa2_mux.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dpaa2/dpaa2_mux.c
> > b/drivers/net/dpaa2/dpaa2_mux.c index bd4596b891..e8689a7832 100644
> > --- a/drivers/net/dpaa2/dpaa2_mux.c
> > +++ b/drivers/net/dpaa2/dpaa2_mux.c
> > @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd
> __rte_unused,
> >   	}
> >
> >   	ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux,
> CMD_PRI_LOW,
> > -				    dpdmux_dev->token, 1);
> > +				    dpdmux_dev->token, attr.default_if);
> >   	if (ret) {
> >   		DPAA2_PMD_ERR("setting default interface failed in %s",
> >   			      __func__);

  reply	other threads:[~2022-03-29 13:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 20:26 Tianli Lai
2022-03-29 13:30 ` Hemant Agrawal
2022-03-29 13:45   ` Hemant Agrawal [this message]
2022-03-29 22:01 ` [PATCH v2] " Tianli Lai
2022-03-31 10:19   ` Hemant Agrawal
2022-04-07  8:33     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR04MB9064953A9D8BE478C87D41C1891E9@AS8PR04MB9064.eurprd04.prod.outlook.com \
    --to=hemant.agrawal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=laitianli@tom.com \
    --cc=sachin.saxena@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).