From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68C3AA0C4A; Tue, 15 Jun 2021 08:31:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF7124067A; Tue, 15 Jun 2021 08:31:14 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by mails.dpdk.org (Postfix) with ESMTP id B126340140 for ; Tue, 15 Jun 2021 08:31:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riMDFP7pu6rio0Z1z2aTwn63EAbUc6x/n0W2Zdbsz+M=; b=2facPRdatecfCsZLDIpZWVIlHYdAdrFOn5fIWfK+Fe1zN7AGNkAEGMPT3SQNvyaZb26Wmj5m8MrKeiZgGsZ0njfQqvoDgwkDUAvkDOEpKb8jIDBYFW32wWPhza30jimQlgdAMBY0y0R1hD76oWdcWm/InwFVpPrx/TuFZhylyps= Received: from PR0P264CA0234.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::30) by AM0PR08MB4241.eurprd08.prod.outlook.com (2603:10a6:208:140::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Tue, 15 Jun 2021 06:31:03 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1e:cafe::b3) by PR0P264CA0234.outlook.office365.com (2603:10a6:100:1e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 06:31:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 06:31:03 +0000 Received: ("Tessian outbound 94919dbe50f5:v93"); Tue, 15 Jun 2021 06:31:03 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8640eb012681.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD13A5F5-BC7F-40B1-AE4E-1FE29CF6B516.1; Tue, 15 Jun 2021 06:30:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8640eb012681.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Jun 2021 06:30:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZH3jsPwIxSQALm+y+7z1Jwa2AOPOH23Wcznx9LXWo4skg4dyyS5B00JlDIT1GD90BWLBoSmjUkz01jv8mZ+f3qLdRJ0qAx2CjSR3lnUzyVdWh43WFOC4QbM3H5M88uo/46sGsoV3hHDuiQcUPzFBrguzD3hRFge/Bd41zvRgf6DyKmTzcfE3bNen0ruFVpCV4e5WSCvYcye5CpJ1kBfY94gSfmiPbLkOPlBScX3u1TQmHvlqkPzuK/i5V3ICi5UM1vb6zeBHhm8Vnv8ddvmTPP6rQWsvT0df3uW6pIzWgGLdcQmbLYtNbsMElZ6APMhGVzBetIh1KaW/RSTGp542sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riMDFP7pu6rio0Z1z2aTwn63EAbUc6x/n0W2Zdbsz+M=; b=DBqtyhRYn0wwJLSIqjTwqYG7D76QM1E0pFZ0iOSUxhdO2CcJTOyAPqHoeBWY51T7UX08RVOAt9zwUTeUSpC6d+lkZvDaTH70MBY9te5vRvgnIlBGu/o3MKDgvMM5V6XU52JVC2Yc+Npi4mCbwjUE41u0Fcv2Pi4qs90JboiBWBkkcGsWwVKRq5CTC5tnyMI1WpVi6lcxI3/6eDFLRHNn/Y3Igf2wCmITvaCGIyQIGN89bKSj5NqsmMkY9BthI76q8jFDSypX1oqzz7tXw1tzfaiu3VvMRtyKfMrIX0s6nhUjuWAgyztMDVE+9R1vUUHY45dZ65WB7ctAT4JpI8CPpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riMDFP7pu6rio0Z1z2aTwn63EAbUc6x/n0W2Zdbsz+M=; b=2facPRdatecfCsZLDIpZWVIlHYdAdrFOn5fIWfK+Fe1zN7AGNkAEGMPT3SQNvyaZb26Wmj5m8MrKeiZgGsZ0njfQqvoDgwkDUAvkDOEpKb8jIDBYFW32wWPhza30jimQlgdAMBY0y0R1hD76oWdcWm/InwFVpPrx/TuFZhylyps= Received: from AS8PR08MB6935.eurprd08.prod.outlook.com (2603:10a6:20b:39e::15) by AM6PR08MB5217.eurprd08.prod.outlook.com (2603:10a6:20b:cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Tue, 15 Jun 2021 06:30:53 +0000 Received: from AS8PR08MB6935.eurprd08.prod.outlook.com ([fe80::eca1:b12c:e2d8:2f3a]) by AS8PR08MB6935.eurprd08.prod.outlook.com ([fe80::eca1:b12c:e2d8:2f3a%5]) with mapi id 15.20.4219.025; Tue, 15 Jun 2021 06:30:53 +0000 From: Joyce Kong To: Honnappa Nagarahalli , "Zhang, Qi Z" , "Xing, Beilei" , Ruifeng Wang CC: "dev@dpdk.org" , nd , nd Thread-Topic: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func Thread-Index: AQHXWt7I3gwEHocE/E2y28kqdd808qsHTxWAgAFVkICAAG/ZAIAD9PHA Date: Tue, 15 Jun 2021 06:30:53 +0000 Message-ID: References: <20210604073405.14880-1-joyce.kong@arm.com> <561469a10f13450bae9e857f186b0123@intel.com> <2cb94e2e1bf74840acaadc389b4745f5@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2829B776C093884A9E21B99CA29F0635.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2409:8a1e:693b:8cb0:71cd:2e9a:ce94:b57] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 579f33ad-6a0a-49c4-9c8a-08d92fc72630 x-ms-traffictypediagnostic: AM6PR08MB5217:|AM0PR08MB4241: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Qxhg4M9dcBMDEZW5lEvN6+0z7ZPjNm9qGfF85xHhR0TmIqZDQRUhIxiBi2xExIvQnGM8Ux0Xeqw2LVe7iHegI8yZ6pVLHY4AU2TC/tiXVSCP+mDJTH2sQ8apRX2tuuPootLDvknW+YoieQCgLpB45NiPDC1E3BHxcVkulXz5eev1e/YD7RjIABz4Dnu2GG9XgHauDAtixdHBKQBjd2NsHFJxUqWl6YfIrKAJ2LWMU9dqcToWV5njc9gBqHc4wY7D1Er7TWr96+Eaf8Hpkww0CznrS8m5JMgw4+cqtoLIUlyRorUJZLEqlQiITiBiqmQJfwWz53HN27Y+Yyf/uoCvEOrAxKofFNamFC1MqtuiHx7XVmU19ll3Q1ieo4Q1yWMCtBh/N9w6PXZ/iK9/5cGpIOzEbuz+0/WPdD9s3Ujb4RIdpeccC+OV4essFwV5OZeDb5DUS92MOFSYbu9jWLUmxGymwiBdq6g2rtU4F1cvAJVgGoLUaOV+ovX7zpT2g/oOwjhpU0ayvKhlmOQcWAMYeIuVoHc31nkJcQd/wkgLd334NQe4gFUBlvRQidMZzVIWmJDin7QhTzQTVbR8BvF1o2l5M5hBYwi2EdTmtvYw+qU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB6935.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(136003)(366004)(396003)(376002)(346002)(38100700002)(186003)(71200400001)(5660300002)(9686003)(8936002)(55016002)(83380400001)(7696005)(478600001)(8676002)(4326008)(66476007)(52536014)(66556008)(6636002)(64756008)(76116006)(66446008)(66946007)(33656002)(122000001)(2906002)(54906003)(86362001)(316002)(6506007)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZN4X5de8HPh2OIzVxv/HVzxvprxF5WQahArhdm8lIhrOpQ4TsQlhzZG4fB2i?= =?us-ascii?Q?o4oPkUYuZT+bstUskwxbXocky+zC80yrbx2P1XjxYS1Oz0U3/o963QxVZcu6?= =?us-ascii?Q?tEo9ClkgfPDohMhAZZFYALOlOxWq41UZtOnJ7jaIMNboz9LSSfZVeWJ9pSQw?= =?us-ascii?Q?P6voz81yVlbOoBg/N48pGY1RQnaEs4kg/TBZY2Xwz9itE7tJDLOzKTJZ22K8?= =?us-ascii?Q?b7IbvhEu23RnTHlGF08K4S3Ufpc5x+09YBCUXfs7SUbvJHTaduXiS+lygw7x?= =?us-ascii?Q?TKGmx6TQPSvJ0pqrmGEmJbqwdRF0Ck1XlW9kadpVyFWOA9U7r4ovu0hTFvHY?= =?us-ascii?Q?RpzL9Di2IJErWTW/H7UQIt4uy0xkNUBg34y/bKjzz9oZT1u19Bq82expgeG3?= =?us-ascii?Q?8jB+2BRSJlj0hGmt3jbyM78KwXSEtPd+qkPv2ki2YdiutG+Z4mAW7tTdtf4j?= =?us-ascii?Q?AyXp/PIRK553Mg/PlExO8mbD/dyEzf6xCabrFNTmLC9VpLJRD6+RGtD06aGO?= =?us-ascii?Q?EI0yWCvdOEXFg9yJECbxy6tDHDIXHM4jJWkZRJ3on/tN3xm7UlJrZkqbfP8K?= =?us-ascii?Q?IY4wNgFEMOASC03TdXnoQgkwIQfVpPgnLJ2/rs18RgLuux8CCShuxgxkcj5i?= =?us-ascii?Q?tlQKhm1SxMkkHLTBRDG3bp464/a+crPI94oKhbyeM0SWg98UctBsrcil3x23?= =?us-ascii?Q?sVAiuB1VpREtfnj3wv02Zi+Hmy6airvh3pY/S0uQMdvxNEDdgwR2R8WrrWf0?= =?us-ascii?Q?y55/THvWkTLsIyuRRlBxfkGnnN0Sy0CsF45yPIyykh1tw3Gcaf69fw1na283?= =?us-ascii?Q?C5lTv5bk93sta4ZEatSCQiCTFUWDIUpplQlcsH6HYrWVLUGpJBACwIX+ds/N?= =?us-ascii?Q?LGeqbWHLKeYhVeBx+KlvZrhTPTg4KY/fa1kVIWdbpQ5GsvMJAu0eubBuM3wg?= =?us-ascii?Q?gVAF0DbMR+e0ks/lJfd/NCOVJZ4AK5x4XzGGPpDVknLFcEEzLNZa+GTq9UaY?= =?us-ascii?Q?uPzclyo5jADZ1+mIbJ6eWjoJ3X3Lgfv8JyZtveMNgURjvHEprw6AQ1HZ3/Hs?= =?us-ascii?Q?azpZfZ1lhESPUThY0NQddu8s3ARe+6zOAj/boANqKmVtyWrpIR4hlTtWI4sJ?= =?us-ascii?Q?qDT015KsKYFLl5iXIxbbO7g030PVepOIxN4YUNA/dCoptw2WVZxv3k9YPCwb?= =?us-ascii?Q?AGwL1117Zuspi/+rjQSXuSjsi1voyOV2g9GZXF6CeFmqh5ab1+NrNGkaNfBs?= =?us-ascii?Q?nr30GMuqTKJC2/Cf9YQeYNBQWsvX5nj1llTuN1LbyAS0aZWSFWDY6nYZXIgI?= =?us-ascii?Q?RrSNNheao/C64PXGvrNWC7FI34AcayKZ1jkLCUdxwrWQuFXiPkMGzeQM4cH0?= =?us-ascii?Q?m67vUygR+1p9RcJlJkrBaInpAmi5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5217 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: effa1154-caca-478b-85db-08d92fc7201d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9OCvtERlT36w7dvSMBPyPel6qrU0h7eEvHazD+OT4omc8UlXxtseEvubkCwyzZgLNNlLe1wSvj/X0XSzVeNDftz+4cs4obitYskUKZFdhSXsjEq9clp8oO0evJ2chR+NBVyrCk0FxTlQNBv4uoliowlM28eKvmR5uigsbCDcRJErs1s/W+PFWbwbnTBtQQlatowEkK+SJ2n30vxXKxsaotng6vCjtRdEOCNIPIUHZboZA57/UAl47/R0bPIdUCL2QR310lcPO4Yi1CPS5LESNaCMk6KnaY6icciDd0O2Lx1X1lPdx0jfY/QnY5h0oW6jwOmAkjHkSqLgPBLbeboyA9D9Z/i7YcL0/WbUb9LVVDEW2OOf0xIbMe1LlK9ly+T+jlbaLSSUx66NGy1WNVKx1qnQfilxSFg68aTk6sQxcBldptYzmfviV/ou653NxRjABHm/uA4IdRfxj4xWRS5SDW7AtRlaIynKlbkNNMivQ4Qp920AVA/2SjsTBki1AJvIMRZZaGgAtnpa8mkF2z1rGksKH4PYEIzEjoc+TpVI+ncgHpAHzH2jeh9Jx90gdrviCqUd9FYCJt0k14+55ub0JVwQARDdUKTdwo8fPZuNNGH61HMVP/194WKw2lt710K02nJhpOJ4k1LnkwluUw8nv5FopVsWGz/gqk/tWzkSqzE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(39850400004)(136003)(376002)(396003)(46966006)(36840700001)(5660300002)(4326008)(33656002)(83380400001)(70586007)(316002)(110136005)(82310400003)(54906003)(186003)(55016002)(26005)(9686003)(2906002)(6506007)(82740400003)(86362001)(356005)(36860700001)(47076005)(52536014)(6636002)(7696005)(478600001)(70206006)(336012)(8676002)(8936002)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 06:31:03.4173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 579f33ad-6a0a-49c4-9c8a-08d92fc72630 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4241 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =20 > > > > > Add the logic to determine how many DD bits have been set for > > > > > contiguous packets, for removing the SMP barrier while reading de= scs. > > > > > > > > I didn't understand this. > > > > The current logic already guarantee the read out DD bits are from > > > > continue packets, as it read Rx descriptor in a reversed order > > > > from the ring. > > > Qi, the comments in the code mention that there is a race condition > > > if the descriptors are not read in the reverse order. But, they do > > > not mention what the race condition is and how it can occur. > > > Appreciate if you could explain that. > > > > The Race condition happens between the NIC and CPU, if write and read > > DD bit in the same order, there might be a hole (e.g. 1011) with the > > reverse read order, we make sure no more "1" after the first "0" > > as the read address are declared as volatile, compiler will not > > re-ordered them. > My understanding is that >=20 > 1) the NIC will write an entire cache line of descriptors to memory > "atomically" (i.e. the entire cache line is visible to the CPU at once) i= f there > are enough descriptors ready to fill one cache line. > 2) But, if there are not enough descriptors ready (because for ex: there = is not > enough traffic), then it might write partial cache lines. >=20 > Please correct me if I am wrong. >=20 > For #1, I do not think it matters if we read the descriptors in reverse o= rder or > not as the cache line is written atomically. > For #1, if we read in reverse order, does it make sense to not check the = DD > bits of descriptors that are earlier in the order once we encounter a > descriptor that has its DD bit set? This is because NIC updates the descr= iptors > in order. >=20 > > > > > > > > On x86, the reads are not re-ordered (though the compiler can > > > re-order). On ARM, the reads can get re-ordered and hence the > > > barriers are required. In order to avoid the barriers, we are trying > > > to process only those descriptors whose DD bits are set such that > > > they are contiguous. i.e. if the DD bits are 1011, we process only th= e first > descriptor. > > > > Ok, I see. thanks for the explanation. > > At this moment, I may prefer not change the behavior of x86, so > > compile option for arm can be added, in future when we observe no > > performance impact for x86 as well, we can consider to remove it, what = do > you think? > I am ok with this approach. >=20 Thanks for your comments, I will modify the patch according to your suggest= ions. > > > > > > > > > So I didn't see the a new logic be added, would you describe more > > > > clear about the purpose of this patch? > > > > > > > > > > > > > > Signed-off-by: Joyce Kong > > > > > Reviewed-by: Ruifeng Wang > > > > > --- > > > > > drivers/net/i40e/i40e_rxtx.c | 13 ++++++++----- > > > > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > > > > b/drivers/net/i40e/i40e_rxtx.c index > > > > > 6c58decec..410a81f30 100644 > > > > > --- a/drivers/net/i40e/i40e_rxtx.c > > > > > +++ b/drivers/net/i40e/i40e_rxtx.c > > > > > @@ -452,7 +452,7 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue > > *rxq) > > > > > uint16_t pkt_len; > > > > > uint64_t qword1; > > > > > uint32_t rx_status; > > > > > - int32_t s[I40E_LOOK_AHEAD], nb_dd; > > > > > + int32_t s[I40E_LOOK_AHEAD], var, nb_dd; > > > > > int32_t i, j, nb_rx =3D 0; > > > > > uint64_t pkt_flags; > > > > > uint32_t *ptype_tbl =3D rxq->vsi->adapter->ptype_tbl; @@ -482,1= 1 > > > > > +482,14 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > > > > > I40E_RXD_QW1_STATUS_SHIFT; > > > > > } > > > > > > > > > > - rte_smp_rmb(); > > > > > > > > Any performance gain by removing this? and it is not necessary to > > > > be combined with below change, right? > > > > I have tested the patch on both x86 and Arm platforms, it seems no performa= nce change. As Honnappa explained, we combined these to avoid the barriers. In this way= , we only process those descriptors whose DD bits are set such that they are contiguo= us. > > > > > - > > > > > /* Compute how many status bits were set */ > > > > > - for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) > > > > > - nb_dd +=3D s[j] & (1 << > > > > I40E_RX_DESC_STATUS_DD_SHIFT); > > > > > + for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) { > > > > > + var =3D s[j] & (1 << > I40E_RX_DESC_STATUS_DD_SHIFT); > > > > > + if (var) > > > > > + nb_dd +=3D 1; > > > > > + else > > > > > + break; > > > > > + } > > > > > > > > > > nb_rx +=3D nb_dd; > > > > > > > > > > -- > > > > > 2.17.1 >=20