From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E4C641DBF; Fri, 3 Mar 2023 07:38:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4146040EE3; Fri, 3 Mar 2023 07:38:08 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2053.outbound.protection.outlook.com [40.107.22.53]) by mails.dpdk.org (Postfix) with ESMTP id B4C4C40687 for ; Fri, 3 Mar 2023 07:38:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kip8jPbEQd/Tn4cZxP0DM2PTYv29q5ygjfJmtVCJJcg=; b=uuM4pQcIywyiHyyC1bQT+VxmjVNU+Z5cpCcW0cLRnGHY6YLUnL1suLKtX+BBfPjXH709/NhYpcYJk0jp6nw01JzYIIX4o6EmWg900KTOlwntNQu0Xs9eYc2+z2m7h4TC4FnjavP8vXDUmMFRp6NxAoHqkSYYECSkZ1pAIfii6T0= Received: from FR3P281CA0196.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::14) by DB9PR08MB6683.eurprd08.prod.outlook.com (2603:10a6:10:2ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.22; Fri, 3 Mar 2023 06:38:04 +0000 Received: from VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a5:cafe::b8) by FR3P281CA0196.outlook.office365.com (2603:10a6:d10:a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.7 via Frontend Transport; Fri, 3 Mar 2023 06:38:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT059.mail.protection.outlook.com (100.127.144.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.20 via Frontend Transport; Fri, 3 Mar 2023 06:38:04 +0000 Received: ("Tessian outbound cfb430c87a1e:v135"); Fri, 03 Mar 2023 06:38:03 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8cf8f47689af.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DB92558-87A5-4701-B08F-673F53D29740.1; Fri, 03 Mar 2023 06:37:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8cf8f47689af.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 03 Mar 2023 06:37:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOWRn9DhEtFlFL+gVKIKdnuH6/EWScsHjNmpzkianEgjAhVgpu0+MOLcg7o2ybhPwEzKTnDNoyznTD656N+2MDk6z+CVBNlFLebpJXxzEFnYey04saSWLBTsWssiDJPWpDJ3RNd4dRT8hwR0QbMIiKtd7D7snw2Kxj2lYj1XDOKEd+ya2Wr8vBKvL2Ugg5aqqyzUmzcnPk2a1DjR8qLzfTM3keyG5wRXUj+qO1AkcxQetqkop2N/y1uuGME/OdxIxkhvZWeIFEOrrY73O18wm9b9hb9YppIqR5rq6eySW2z50tw1sNzCbQJsMyRKxERec5hxHSaR3lrRo1kBJYIwoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kip8jPbEQd/Tn4cZxP0DM2PTYv29q5ygjfJmtVCJJcg=; b=NDhQRfVLh9SqaYJQLPQ2wLnd5fBYzzGlsQpLCLf53Gdub5zktzF4cJaBD3eOQ1+/66LF3zLfIzgI0zlsyUABbEfgCIKYkU7LIcJkT3/RE5boaTY251M3MnZFRKA26wke9ecKzrf+NHHoeaS39MWZfkW6ik117l+QKtxbpHYdBEUrcD3CwWOVbNOk9ixmrklcg+3V0ndsbtQIY1F3x9euXXbhA/MQ/MqjWjJUEH8XLGCZOz9I/0Nf7gyhVY0JEq5F7lEUOK/yRq14h/yoBaGrFns/gC/cVdmWRVyYfwEQospAxOfsOA3e/rXuD6Rx+VC+EseDjlpQ6FVlgcTM8ysgiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kip8jPbEQd/Tn4cZxP0DM2PTYv29q5ygjfJmtVCJJcg=; b=uuM4pQcIywyiHyyC1bQT+VxmjVNU+Z5cpCcW0cLRnGHY6YLUnL1suLKtX+BBfPjXH709/NhYpcYJk0jp6nw01JzYIIX4o6EmWg900KTOlwntNQu0Xs9eYc2+z2m7h4TC4FnjavP8vXDUmMFRp6NxAoHqkSYYECSkZ1pAIfii6T0= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by DU2PR08MB10065.eurprd08.prod.outlook.com (2603:10a6:10:497::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Fri, 3 Mar 2023 06:37:07 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f%5]) with mapi id 15.20.6156.021; Fri, 3 Mar 2023 06:37:07 +0000 From: Ruifeng Wang To: Kamalakshitha Aligeri , "jerinj@marvell.com" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "sean.morrissey@intel.com" , Konstantin Ananyev CC: "dev@dpdk.org" , nd , Kamalakshitha Aligeri , Honnappa Nagarahalli , nd Subject: RE: [PATCH 2/3] examples/l3fwd: removed hash entry number Thread-Topic: [PATCH 2/3] examples/l3fwd: removed hash entry number Thread-Index: AQHY+G+6uFQUq617SkuCBTb9/skJza7pPshg Date: Fri, 3 Mar 2023 06:37:07 +0000 Message-ID: References: <20221114212533.2871770-1-kamalakshitha.aligeri@arm.com> <20221114212533.2871770-2-kamalakshitha.aligeri@arm.com> In-Reply-To: <20221114212533.2871770-2-kamalakshitha.aligeri@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 44B49BA0621D8C4DA2FDF501B2358ACB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|DU2PR08MB10065:EE_|VI1EUR03FT059:EE_|DB9PR08MB6683:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b878800-397d-4828-3a5a-08db1bb1d781 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4/oBlF1mqfGI/gT/Z4x+XJhTaHx0BnNNwgQMA7m8ts6Sfjddf0xPGTpGVYbP/QLrAlKCoXgCheHHf27xJfPNL/QketvygK/t3ZoD0CRrJ8KJn4s1+JDH7zkqaoLKG0ypAvT2XEI7okHHZW7i/MgBu3Z1w3fU0BbdWRZZn7/IrPzEZazisG/jJonJwfUaPVLWJGnSRsESjll17hc4mEmq0CqN4WWBSsqdyOxgFr6A108gEI1e25qGcZ+UVS6Gb+0Utv7hFGu9SzfbvAjPpyVgRc7KKQaSg8CTA3C7dsdTma+M6IlqHrXgVHxcElJXEiR03dq4+bdS3nipEhXRKk6ttEgvISOV4SuzQvswH2yW4ufPGC9rkNb5PlaUw6FQOKplfO3Q47nQ5LbM+yxpdgh2VkuT/J/27Xo4W/Dl/Gjmp6SXr0WwOihn3m2HcuOmqnrXWErN0NQtmPese+jh3ndFCWxgJ3FmPSJrCkA3GjpRfPT4EBW2/peHM8/eJaWclgaobQiSkJa9mDKWfq1604ulHl5LnS5NPyMmYMEe5mbhlO4bky5vnIBCUcRDvVyxahh12Jz4VHey3J5Yp8+HaWhEJXcqCEwBqvpXiuK66tRvWvAJhyZFwmOJDSuw8MCvhJyC01/HUkqE/Odnn+GumjI5ozP5Q0pZT3pQRMtRXtrfD5cTMvutPyhXnYi+bPSqLgjXQ8A2DkMz/oXPYra0OJr9gA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(451199018)(186003)(53546011)(6506007)(2906002)(9686003)(4326008)(26005)(316002)(41300700001)(110136005)(54906003)(76116006)(7696005)(8676002)(66556008)(66476007)(66446008)(64756008)(71200400001)(478600001)(5660300002)(38100700002)(122000001)(8936002)(33656002)(86362001)(52536014)(38070700005)(55016003)(83380400001)(66946007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10065 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4c14961f-7dc2-4170-b012-08db1bb1b5c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ceBt3t9R67cQtsZGlM4/iSTq5RwAix3jys2VU6psJFLQZP9MMmOG0mnCxoAsw+AUpIZqItk0+fze+cZJ9EbRWhCBP2MBeVS9+UzcLpMHpyUbZg2Bv8Q57UTlIEF2Vs12r5bgQOrVhp3HIZx7q3fnl/1HGlf+ydDXIlD0h0H6w1VYS3jriQvJL7C8NaWnUID+qkkLz+HCiYkXmnSdUpigMlB9Groioz/+9SDSTJY2IdXrhSDWR0PE/SPZ1FLHH8+QX1G2Lci3mJsv86KFzHhVE/nn+dxTOacwR0iltYi7dWuF65qL2y2D3WsFZn2G8YlFk0l83PnVhnC0pv4ipvKPrkgFAEQoATkwDgtdriKQBKwh8ouNywBGCjZ1hDR0fWEa1XYAVGK00JYQoZFEtyfnz3sxbDNjfmXXmmgfd9v05005Xwoeg7UEpckrwIU1x0vHyOOSWJCL1AE4zo3NWoTe8Yuea4STz2YGpObiAcPQhEODa/x/Qh0Env0+jPoC5wdJYwZoTRvfwLwz5D8nL1jTKI3bAkmRiBeXOk/i435eWGYp8CEfE46MBXk1caRC3WhcLKGk/nikYEsMHv1EKBr5UiEoOVUuTzDh7fcw0M/nM6usPJU0VKBzYoGdCx7IiRLe5U8mftvkCzWhIQh5TQrWaGfi3Yex/0rHEXlbMTR/vZi2taOOcnRolZbe4VEhkrmw0v0N5SwRqqRiG08I/4RpzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199018)(36840700001)(40470700004)(46966006)(47076005)(40460700003)(53546011)(336012)(6506007)(26005)(9686003)(186003)(41300700001)(316002)(110136005)(54906003)(4326008)(8676002)(70206006)(70586007)(7696005)(2906002)(52536014)(5660300002)(478600001)(86362001)(82740400003)(81166007)(8936002)(55016003)(33656002)(82310400005)(40480700001)(356005)(36860700001)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 06:38:04.0695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b878800-397d-4828-3a5a-08db1bb1d781 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6683 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kamalakshitha Aligeri > Sent: Tuesday, November 15, 2022 5:26 AM > To: jerinj@marvell.com; thomas@monjalon.net; david.marchand@redhat.com > Cc: dev@dpdk.org; nd ; Kamalakshitha Aligeri ; > Honnappa Nagarahalli > Subject: [PATCH 2/3] examples/l3fwd: removed hash entry number >=20 > hash_entry_number in l3fwd is not being used by both lpm and em lookup me= thod. Removed the > global variable hash_entry_number and the function that parses the hash-e= ntry-number flag. >=20 Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM") Cc: stable@dpdk.org The code was used to populate many EM route entries. It became obsolete aft= er file based config was added. > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Honnappa Nagarahalli > --- > examples/l3fwd/l3fwd.h | 1 - > examples/l3fwd/main.c | 37 +------------------------------------ > 2 files changed, 1 insertion(+), 37 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index ca1426= a687..b55855c932 > 100644 > --- a/examples/l3fwd/l3fwd.h > +++ b/examples/l3fwd/l3fwd.h > @@ -55,7 +55,6 @@ > /* 32-bit has less address-space for hugepage memory, limit to 1M entrie= s */ > #define L3FWD_HASH_ENTRIES (1024*1024*1) > #endif > -#define HASH_ENTRY_NUMBER_DEFAULT 16 >=20 > struct parm_cfg { > const char *rule_ipv4_name; > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 71a30180= 36..a4f061537e > 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -89,7 +89,6 @@ uint32_t enabled_port_mask; >=20 > /* Used only in exact match mode. */ > int ipv6; /**< ipv6 is false by default. */ -uint32_t hash_entry_number = =3D > HASH_ENTRY_NUMBER_DEFAULT; >=20 > struct lcore_conf lcore_conf[RTE_MAX_LCORE]; >=20 > @@ -395,7 +394,6 @@ print_usage(const char *prgname) > " [--eth-dest=3DX,MM:MM:MM:MM:MM:MM]" > " [--max-pkt-len PKTLEN]" > " [--no-numa]" > - " [--hash-entry-num]" > " [--ipv6]" > " [--parse-ptype]" > " [--per-port-pool]" > @@ -419,7 +417,6 @@ print_usage(const char *prgname) > " --eth-dest=3DX,MM:MM:MM:MM:MM:MM: Ethernet destination for port X\n= " > " --max-pkt-len PKTLEN: maximum packet length in decimal (64-9600)\n" > " --no-numa: Disable numa awareness\n" > - " --hash-entry-num: Specify the hash entry number in hexadecimal to b= e setup\n" > " --ipv6: Set if running ipv6 packets\n" > " --parse-ptype: Set to use software to analyze packet type\n" > " --per-port-pool: Use separate buffer pool per port\n" > @@ -479,22 +476,6 @@ parse_portmask(const char *portmask) > return pm; > } >=20 > -static int > -parse_hash_entry_number(const char *hash_entry_num) -{ > - char *end =3D NULL; > - unsigned long hash_en; > - /* parse hexadecimal string */ > - hash_en =3D strtoul(hash_entry_num, &end, 16); > - if ((hash_entry_num[0] =3D=3D '\0') || (end =3D=3D NULL) || (*end !=3D = '\0')) > - return -1; > - > - if (hash_en =3D=3D 0) > - return -1; > - > - return hash_en; > -} > - > static int > parse_config(const char *q_arg) > { > @@ -852,14 +833,7 @@ parse_args(int argc, char **argv) > break; >=20 > case CMD_LINE_OPT_HASH_ENTRY_NUM_NUM: > - ret =3D parse_hash_entry_number(optarg); > - if ((ret > 0) && (ret <=3D L3FWD_HASH_ENTRIES)) { > - hash_entry_number =3D ret; > - } else { > - fprintf(stderr, "invalid hash entry number\n"); > - print_usage(prgname); > - return -1; > - } > + fprintf(stderr, "Hash entry number will be ignored\n"); > break; >=20 > case CMD_LINE_OPT_PARSE_PTYPE_NUM: > @@ -963,15 +937,6 @@ parse_args(int argc, char **argv) > lookup_mode =3D L3FWD_LOOKUP_LPM; > } >=20 > - /* > - * hash flag is valid only for > - * exact match, reset it to default for > - * longest-prefix match. > - */ > - if (lookup_mode =3D=3D L3FWD_LOOKUP_LPM) { > - hash_entry_number =3D HASH_ENTRY_NUMBER_DEFAULT; > - } > - > /* For ACL, update port config rss hash filter */ > if (lookup_mode =3D=3D L3FWD_LOOKUP_ACL) { > port_conf.rx_adv_conf.rss_conf.rss_hf |=3D > -- > 2.17.1