From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B31D2A0032; Fri, 14 Jan 2022 10:05:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D4AF4276F; Fri, 14 Jan 2022 10:05:14 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140081.outbound.protection.outlook.com [40.107.14.81]) by mails.dpdk.org (Postfix) with ESMTP id E840040DDD; Fri, 14 Jan 2022 10:05:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bUDz9gEwmWsQ812Wgt2DmqB7SfA/NFxR6xGTQswALiE=; b=NihjF492jsnY9EnLo+T3WZwjlpNK0PVOIHMSoht7zjj+vggsSmDsFNQzYXl/ojOMLm6ytN9k74JM2C08sVuiicq2/o1RQV1TPn2jP3kS6lVTGqPV7TsH4prMmAj+j9oyJumJ1vXhT8HXB4sRO4FpAgfiafJJZFzFbWFEU78gH/w= Received: from AM0PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:208:ac::22) by AM7PR08MB5352.eurprd08.prod.outlook.com (2603:10a6:20b:10e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Fri, 14 Jan 2022 09:05:11 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:ac:cafe::a5) by AM0PR07CA0009.outlook.office365.com (2603:10a6:208:ac::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.3 via Frontend Transport; Fri, 14 Jan 2022 09:05:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9 via Frontend Transport; Fri, 14 Jan 2022 09:05:11 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Fri, 14 Jan 2022 09:05:11 +0000 X-CR-MTA-TID: 64aa7808 Received: from b3495dced82d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E3B855E7-6D93-4301-83D2-E83AD307768D.1; Fri, 14 Jan 2022 09:05:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3495dced82d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Jan 2022 09:05:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RfXH97sVVG9Y9lQ6p542fquAu6qMuPqH8QKSqozCoKTSSc7lB18iRs+EvBO592pcJICGIQy+sTZEGdsL+NAtI3gN0SX4ea3agpNfp7fA8acfhIj8qqivmb0BDz/xark+2LNIDjUwGXv5QcDQWw3TZvvmp1NYl4DAYKkG6DZzcb1gF4nkdrkgZY9tbXSR+ybSfmXeFRCOTHWUn/UQjLtsh2e2Sxc0qTO4QvQESyNpEZFdW/gao1HjzLhqeeOrSHIMQRiWEAg6FCCfrfdu4dONXHc4NG9oI2QAYSyz5gKJeDuuXM5ktJLCP/NYncRxeMCh1kVDUHF2cFdycwx2rPsP0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bUDz9gEwmWsQ812Wgt2DmqB7SfA/NFxR6xGTQswALiE=; b=Mnhvw7kSYOKJJKSNlE4Ma4n6aQ7E0TMAIVZm+jOkn7aRCq7EzjEeHKKrPuIlUqEU0ufOQ+I+Mz/7szJuIv6KL82OrUqNo/pN0YsEaGPsdeFacnf0f0z/qFm4NNzgsTQ4wFnId3pNAxE5TVt8AcJ0xeknt7q42D+aU+Lzm+/k+tMMA00dQ1VYAxtwvsDvJuk8MiJSFoPUJ5TPwyVjAB62qHGxvaI1GDrkPQAJ+mACAbbd7maExH3QYng2uCk3QIS9nDMu1nK05oKQ0mlo2pEhGHk3+2F+TxbVuBbaFTTYYahcqeoaZX0hbTCfB03JcQXxsik1sio7iQZIqBBAljtRvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bUDz9gEwmWsQ812Wgt2DmqB7SfA/NFxR6xGTQswALiE=; b=NihjF492jsnY9EnLo+T3WZwjlpNK0PVOIHMSoht7zjj+vggsSmDsFNQzYXl/ojOMLm6ytN9k74JM2C08sVuiicq2/o1RQV1TPn2jP3kS6lVTGqPV7TsH4prMmAj+j9oyJumJ1vXhT8HXB4sRO4FpAgfiafJJZFzFbWFEU78gH/w= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by AS8PR08MB7222.eurprd08.prod.outlook.com (2603:10a6:20b:345::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Fri, 14 Jan 2022 09:05:03 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f9ab:bc8d:4319:666d]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f9ab:bc8d:4319:666d%8]) with mapi id 15.20.4867.012; Fri, 14 Jan 2022 09:05:02 +0000 From: Ruifeng Wang To: "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" , "stephen@networkplumber.org" , "juraj.linkes@pantheon.tech" , Honnappa Nagarahalli , nd , nd Subject: RE: [PATCH] build: add missing arch define for Arm Thread-Topic: [PATCH] build: add missing arch define for Arm Thread-Index: AQHX8yPV6Qp377XxYkqvBUJxGOM/aKxhYOcAgAD6cLA= Date: Fri, 14 Jan 2022 09:05:02 +0000 Message-ID: References: <20211217085430.820773-1-ruifeng.wang@arm.com> <10596176.5MRjnR8RnV@thomas> In-Reply-To: <10596176.5MRjnR8RnV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F06BDCE19354FA4CB76D2B681B2AB5BC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a327cc50-3d0a-40ac-5690-08d9d73cf886 x-ms-traffictypediagnostic: AS8PR08MB7222:EE_|VE1EUR03FT016:EE_|AM7PR08MB5352:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ck7Htd8HmYRcCOlbbbu1lPEEXHhlenReN0KxZlw/lCk4j0UZ5pJ3BLMw+bE6V1KzUNBfAYC5ocXcD9K7QEfj4XlV4uSJmJItsWpRInPAghFI2RwbQ2vEVN2962thuIgfPaCTroHUmEzflC/0ruNQAK5FqOSwRc4aBQqnxkobDGiY2fLlrziFkf9Ux9Ve/jc9uKOuVAFngb5pjP1i++NxYKKK+fctFuZgB9OKmmpW9SO1KVtbsLjYqsMH6bM2BfkiP315w8fa6hljZ+iDqJJyhmCJiIV/UsbmonGwfJ+0g7qtZjnmxbroIKk3mA8np4VsgM2DhQrf7EwnlHJj2XoNU9HrowEjpDBq+xD3hHgPDSbFFS1cBufOqJh+l7l7C4zNAYhNFFQgvg/pudqgqyD8H6wXan26ugk23/Ifa3Cm8q34T45qzkAtCdbkyLuclm21lcDs1m2cc499E8fTcSBdXoYvitsxyK4sxerkqZwz9oaiBSQ1k6r79wDZkijDzKJKtIQ9VV0AHJDwsSwY1la2J/9imi2Ck1thuDoa0Ly0ikFOL+5jO9p9fZEpUSbX0TdUQme/mQmI6UHEYKCWSPPCY9pKmqQu3KSEQ785Ygr2b7VYrsAElH7Hph3gUr3JrcUVXvF+AO/SfKw1rbawgGLGhf+BZo3ggRVKWXAJczv83siO7mqJVCNb7atQEYONTnQaJyz0sAeDlbU9vdVsjQKW4g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(53546011)(186003)(33656002)(122000001)(7696005)(9686003)(38100700002)(2906002)(5660300002)(83380400001)(86362001)(26005)(508600001)(38070700005)(55016003)(52536014)(8676002)(64756008)(66946007)(66446008)(66556008)(66476007)(4326008)(76116006)(8936002)(54906003)(316002)(6916009)(71200400001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7222 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f2d8ba8d-504c-4e34-065e-08d9d73cf345 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QuzP7lOdHS06L3Qjhr9w7wNQ46c8b1C1/x/KNe/3np1QVScPOmNDRHV9EDiZOmZavSn72NDEJ2ISwHA8C6fYr1hkVZdbhPgcxA1rKsiyh01L+CJiW9Pj7JV3U/gn5j0W4L5YVTP3MdWGp5xI/JSUyWv49Om1tUaTUB91hr2MRX/lMqEpgw0Gv2gl4PTNrD+7t5j/o6dcfR/EVRa3gxkRB9/R7UjLxgCil+3uJ9iL2uVOJFzGZWySJpm9BpdqH6hplWdtfZpru4JjXDHUgXWQFBFRN47MrKE8Qbdktn8rULawCKeuum2/tz06ROdK3XINdijZPxaflIHJbYC82swup5FYCQEbYcme13r6A0/y9s5xxEsQiYRGBCj8v+eUpXAY8nqzRk2LHnYR4bwD0ItK8H3NOEgDll0hdVEGH4ttgClxwZZ9z4VIGHwNZpilVFSGpKDQNq3/74C1K9cJYDSp7yuHFWxO8lQBCsSYEoIKfPTBl172MkwMHVve21C5YgYCLBjxy9+h2jZ5lxaSczzPc+YRzj442LW9xV7kSapkYux4UsD4GJTOozqbq6yUyb0zaLIPSlkx2BXEBBC9V1aDNu7trEkDWkK4+D6W5C+61FyC/T0+Wx7DjAb0mXbRyZXlLZ6neIvW6uaVxZkopT6NHbLhTaHEr0CTkuMrinnz8yRnm3K42yJYZl23fgdOj+81mvxZ6bW5RpaYTTmQFDrw+w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8676002)(5660300002)(86362001)(336012)(450100002)(9686003)(8936002)(316002)(54906003)(36860700001)(6862004)(4326008)(186003)(26005)(52536014)(53546011)(70206006)(356005)(47076005)(7696005)(55016003)(70586007)(83380400001)(2906002)(33656002)(81166007)(82310400004)(508600001)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 09:05:11.5741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a327cc50-3d0a-40ac-5690-08d9d73cf886 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5352 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, January 14, 2022 1:33 AM > To: Ruifeng Wang > Cc: dev@dpdk.org; stable@dpdk.org; viktorin@rehivetech.com; > bruce.richardson@intel.com; stephen@networkplumber.org; > juraj.linkes@pantheon.tech; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH] build: add missing arch define for Arm >=20 > 17/12/2021 09:54, Ruifeng Wang: > > As per design document, RTE_ARCH is the name of the architecture. > > However, the definition was missing on Arm with meson build. > > It impacts applications that refers to this string. > > > > Added for Arm builds. > > > > Fixes: b1d48c41189a ("build: support ARM with meson") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ruifeng Wang > > --- > > ['RTE_ARCH_ARMv8_AARCH32', true], > > + ['RTE_ARCH', 'arm64_aarch32'], >=20 > Why not armv8_aarch32? Thanks for the comments. Agreed. armv8_aarch32 is consistent with the RTE_ARCH_xx macro above. >=20 > [...] > > dpdk_conf.set('RTE_ARCH_ARMv7', true) > > + dpdk_conf.set('RTE_ARCH', 'armv7') > [...] > > # armv8 build > > + dpdk_conf.set('RTE_ARCH', 'arm64') >=20 > Why not armv8? >=20 > What I prefer the most in silicon industry is the naming craziness :) While armv8 usually refers to one generation of the Arm architecture, arm64= is more generic for 64-bit architectures. And what defined for armv8 build is RTE_ARCH_ARM64. So for consistency, arm= 64 is better?