From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D0C142FAD; Tue, 1 Aug 2023 05:19:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8C0140A7D; Tue, 1 Aug 2023 05:19:05 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2073.outbound.protection.outlook.com [40.107.7.73]) by mails.dpdk.org (Postfix) with ESMTP id ABEC9400D5 for ; Tue, 1 Aug 2023 05:19:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQv8xDgJcL+S5RK6QRrT6MbtJWv5Z+1MPUTIy6NQaOXaN8GQkfBtL12Pdu3LCT0+gCmyruRhSDoHZvbOMuL1H5LNJ7gCvGuVh+NzTSxWrYcsexrzvxsZYPxdOpCxzXELnchY5+1jKQ77voyD2vBDK7CaGrO9DIXi3WJ2vq3LpVefDvURu/TuL6Ae8fEXAv/6K+LWYT/qYeUSJJG812LCzwLh30xFzujNI/TTR8uk/FC+LKKTcebFm+YUC/hMnOs48Hcgi3rVFdEkwbxzLpK7W0EIVXPubdmhHTeiC5WIquG3ZmQjpC7e8TSmrjnoo1NGkY10ij/ZbF9PUQ3nRA4lrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYrZzt67N/kbBQW9eGzt6Jibn58699fGHxTUG+O/Qo4=; b=M16SSWR8/FyeS3h66C5428QU9YIXWon16sGkapIlOZIHY3GOa3iyxODTwOginbizELF8G9HJKGmR3YyrTbDFQKFOb4XJ/jkIDt5hWpDm02s3/DcmQ+Fu2CPHRp6r0+zsYO4ia25Ft/aW+srhPzAM5zpV/zf8SudD3KWKoMTTLb3jAkR2p1t5oWAhp1CAwbxpJf6uLmEZ7PWfNFd4hXMRmQ9nOBclrtZSnX9sdFCnS8ob33HFs0oveEk9fQ7aJVVRdNV6A+Nu+CaxN2Ls9XpWgpM3GFf0FvlVMvHKxu6nur8o4IJbICxrdgITZk6MWK4D6jqJNU2AvxEaFA0DWcdrGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYrZzt67N/kbBQW9eGzt6Jibn58699fGHxTUG+O/Qo4=; b=RAkZiqzHw/I2OPQyp++inU4763t6jnHe4ThIfEgLTjLQ1eJNdXomUJCFlnKxEAzabdI9mv7zG3K4da2Nu/RJolZDuKvPhBFt4Qy9wa/Ea8Oxi45WqBCfB/nsxnA607aRVA9YSFdAP9H5TefANkk8pXv18JyoF391gHN5fMJsPTg= Received: from AS8PR08MB7718.eurprd08.prod.outlook.com (2603:10a6:20b:50a::22) by AM8PR08MB6323.eurprd08.prod.outlook.com (2603:10a6:20b:354::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 03:19:01 +0000 Received: from AS8PR08MB7718.eurprd08.prod.outlook.com ([fe80::70e8:2daa:5a39:dc50]) by AS8PR08MB7718.eurprd08.prod.outlook.com ([fe80::70e8:2daa:5a39:dc50%4]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 03:19:00 +0000 From: Feifei Wang To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "thomas@monjalon.net" CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , Ruifeng Wang , "ferruh.yigit@amd.com" , "konstantin.ananyev@huawei.com" , "andrew.rybchenko@oktetlabs.ru" , nd Subject: RE: [PATCH] doc: announce ethdev operation struct changes Thread-Topic: [PATCH] doc: announce ethdev operation struct changes Thread-Index: AQHZrk7+YdFcGOlznkOn0UqKTFzR/K/PauaAgAADVoCAAAM6AIAAA8KAgAABAACAAATsgIAFdM3g Date: Tue, 1 Aug 2023 03:19:00 +0000 Message-ID: References: <20230704081006.1202932-1-feifei.wang2@arm.com> <1783013.TLkxdtWsSY@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87AA4@smartserver.smartshare.dk> <3047655.CbtlEUcBR6@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87AA5@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87AA5@smartserver.smartshare.dk> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6DB970AED8A6A841A19A51EAA4624690.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7718:EE_|AM8PR08MB6323:EE_ x-ms-office365-filtering-correlation-id: 06987a2f-9f49-466e-0dfd-08db923e0cd4 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EASnlngtOCVh1fAxFuPpPiV42AkWtI9O5N17IxGp+429i9ghokp6Ub3uKhPLMtQ/W/K7TozDfeq/6CRH8eL+sq9hVcP/6cFtHGymFbbc958Ks7YvsKtE8+/i9UJ/qDN5M0zJpbiFCqqUYmi8B11KIaI8UdsXhrY+bqY1INFJyEQ/grDcSlm5MVfebgorRYyadNLFBJDFggRd7h4mIlpUo79Vp8saL27bNrXns2hUyg802l8zAkOoA45lrwVahYL9Hoi512x4+R5m21lnf9R002NF/TyW0sK1HWhYHk8zD7/lj3O+OU20lf1iahhvCug5VOQe9yOl0WfiEbY/fwlXiC1ADtCpdLdK0fOawt+SDCrB16GJccRurmj339/uwwg+Cztirvu9LVcW1//5KrvvC8S/qew4nFUYsQiC561FL8UKpvh5mHOtL0xSaN8gyXE01yxhGf4ZKc8/s8YnUG8huGQzCoP3AFZHEa1qWkBYt82RQRyhkfZxH+/vwHqIFzFhTdYzIH6F+jbGV13D/LBn1JJHy3Ekh7ZJcsZ49JlHNAWMU1anzkcbVqabtWxpfJtDbdna3SiqW9sSeeSXDaBGjshxnYIKoN87cJJjUkLKrMdmIeE0m7ypyQ8P08w6ABFK x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7718.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(9686003)(7696005)(55016003)(53546011)(6506007)(26005)(83380400001)(186003)(66574015)(76116006)(33656002)(66946007)(52536014)(66556008)(54906003)(110136005)(122000001)(38070700005)(41300700001)(38100700002)(86362001)(66476007)(316002)(5660300002)(66446008)(4326008)(8676002)(8936002)(64756008)(2906002)(71200400001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?XwBoPv9ZCWqYCn/HIyeYV+66xpxBhBbh0C3eIX0PGxnsQSY+eXIFzPEueQ?= =?iso-8859-1?Q?yqqB9Dx+CSwj6cV8uCN6Ww1bAGfU1drWVy/9sfcPbJjctnlbNZ64qpU15v?= =?iso-8859-1?Q?GG1vcYMnltCG/bGrr/ScpznjsDYhoarF+VNfMYUzNDwJqc/Cq6tDzTAlmI?= =?iso-8859-1?Q?etkHogmgf1PsYsXasqhRWbLMCsdssQfiaSX19aPBTbrOQm0BlgVbtzK56s?= =?iso-8859-1?Q?TEFKBLQATIcfKjuXg/uImG+PWmN4KUfiF2j7fMGrxZJODz9fmHwfWEInEb?= =?iso-8859-1?Q?wdmc4zb6ged4RrDlFXsl8bApUMgeaLh9rn+KDHT4BF+P2rDBmK3VET+l+C?= =?iso-8859-1?Q?M/D4XU0+MC3EGB83btafODr/UG9J43HpS/fjhpWgdv+uLe+fwBoVAzQeHk?= =?iso-8859-1?Q?LJOIge+P0uX2aGFOQ8z9AsWyS4MJnLPvT2ea/8beBaasiRi4OL0PWp/P4D?= =?iso-8859-1?Q?C2sSXg2urHunz+phdLKUo1i2xHHFwnzwMym0w3ChqmZ1IiKYUBtdXO/un0?= =?iso-8859-1?Q?XCHE9KyeIWghBwaI6RsKigOHHA0xZQnfRQ5py2NB1ny2DOWZYoTiyPgLri?= =?iso-8859-1?Q?BFEIEYNU0ReINPi6CQSc8II7Y0LoEXzyFlTV7oFCGO1XTJila9eW4cdM61?= =?iso-8859-1?Q?hClLJ91fR9UvI+IlSqopIaR3qu9lolVfPyrI/vgT2n5rZX9RjF/kngptKv?= =?iso-8859-1?Q?DUxdlOHbWk1yALwH7nodO88dENcfOaf2Uef0Y86X50Bd4o1Nnk+e82gB1S?= =?iso-8859-1?Q?KJRdvVycSqvy+sn9d3b0o0n44rzqTktLqoZYnTQ6vCZX3vvgcjgiTzhThE?= =?iso-8859-1?Q?32mjFwhZ27CcVDisQitBDuIbgMCzcUjwcEpVZx8UQ/GyG1nOFH4ECLFmUj?= =?iso-8859-1?Q?FuvWazNX+msWfmVVPUWdN1D0pM1wl4jE2WWwyIkKSN65iua/EcVOtpr0UX?= =?iso-8859-1?Q?UIXxduf7WoFx7JZQa2IFJSfxJlCDHZREIgqGNpDKQRppyXsyhKCPG57+SV?= =?iso-8859-1?Q?FNNGDH06Gn4h+SJS8Zpji6IWNAyWMcNXqZXhkj8sWpJMIIZIVnfSUy/vf4?= =?iso-8859-1?Q?4znCHXCssb6MSTr8w6yL/KPM5+2pCHWrgaNROzefwGAp4BH17VBrUs7/Dr?= =?iso-8859-1?Q?tYbbg2nCU1Dhj4rhpQnrWjy/HY+IUpbo48uF2jQjFGzgLFiPbXeRdam+PM?= =?iso-8859-1?Q?wyzK9vrmr64OPJy+ZNAufje+9u8SLmJoqhMrj5GAwbs7ot+cIyJg9L8y4V?= =?iso-8859-1?Q?UNZzPSaRm3/CoMQizoeoyZqTRu9Sgywx1mE7MRanVfdc+2dGDbcfy3zQUR?= =?iso-8859-1?Q?lK79MduZFYcePHqu19l+ElZN75sWUQBsS6WdAb7OYt8Tu/g81BcNbOOJCS?= =?iso-8859-1?Q?YlAJdTG5Kk4MCGqb3glesHObocljvYyLxjfbOnEO0R++vYD2lj5QuC2y5O?= =?iso-8859-1?Q?RewDgWzD6kB2HW432O/wXiqLpGSU1cEQCFov46LrjUI26ZDa1P6c6I7Gcq?= =?iso-8859-1?Q?9c/gCLIEX1UWP2Sfaf6nLANyIgGT9nW+1CF+0pZ8s5CBOjQHTxBT7SfohO?= =?iso-8859-1?Q?fH1q70miPhGEK0ZNdKibpWbGBRbVyOjFIrq/fhIxytU5KhKdrvE7NNwenv?= =?iso-8859-1?Q?8mjvxPYZRn6AZMk2AdeP6KHDa6sE4oP/hD?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7718.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06987a2f-9f49-466e-0dfd-08db923e0cd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 03:19:00.3463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DSDkjjUFacI49bSTDQYhRfPEnaU5mB4DD8ac5UwXnhIr5liUE+EJR7n9tI25oBc3o4wW0sspfGKy8Yg+uG89rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6323 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Friday, July 28, 2023 11:55 PM > To: thomas@monjalon.net > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Feifei Wang ; > Ruifeng Wang ; Feifei Wang > ; ferruh.yigit@amd.com; > konstantin.ananyev@huawei.com; andrew.rybchenko@oktetlabs.ru > Subject: RE: [PATCH] doc: announce ethdev operation struct changes >=20 > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Friday, 28 July 2023 17.38 > > > > 28/07/2023 17:33, Morten Br=F8rup: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Sent: Friday, 28 July 2023 17.20 > > > > > > > > 28/07/2023 17:08, Morten Br=F8rup: > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > Sent: Friday, 28 July 2023 16.57 > > > > > > > > > > > > 04/07/2023 10:10, Feifei Wang: > > > > > > > To support mbufs recycle mode, announce the coming ABI > > > > > > > changes from DPDK 23.11. > > > > > > > > > > > > > > Signed-off-by: Feifei Wang > > > > > > > Reviewed-by: Ruifeng Wang > > > > > > > --- > > > > > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > > > > > 1 file changed, 4 insertions(+) > > > > > > > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > > > b/doc/guides/rel_notes/deprecation.rst > > > > > > > index 66431789b0..c7e1ffafb2 100644 > > > > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > > > > @@ -118,6 +118,10 @@ Deprecation Notices > > > > > > > The legacy actions should be removed > > > > > > > once ``MODIFY_FIELD`` alternative is implemented in driver= s. > > > > > > > > > > > > > > +* ethdev: The Ethernet device data structure ``struct > > > > > > > +rte_eth_dev`` > > and > > > > > > > + the fast-path ethdev flat array ``struct rte_eth_fp_ops`` > > > > > > > + will be > > > > updated > > > > > > > + with new fields to support mbufs recycle mode from DPDK 23= .11. > > > > > > > > > > Existing fields will also be moved around [1]: > > > > > > > > > > @@ -83,15 +90,17 @@ struct rte_eth_fp_ops { > > > > > * Rx fast-path functions and related data. > > > > > * 64-bit systems: occupies first 64B line > > > > > */ > > > > > + /** Rx queues data. */ > > > > > + struct rte_ethdev_qdata rxq; > > > > > /** PMD receive function. */ > > > > > eth_rx_burst_t rx_pkt_burst; > > > > > /** Get the number of used Rx descriptors. */ > > > > > eth_rx_queue_count_t rx_queue_count; > > > > > /** Check the status of a Rx descriptor. */ > > > > > eth_rx_descriptor_status_t rx_descriptor_status; > > > > > - /** Rx queues data. */ > > > > > - struct rte_ethdev_qdata rxq; > > > > > - uintptr_t reserved1[3]; > > > > > + /** Refill Rx descriptors with the recycling mbufs. */ > > > > > + eth_recycle_rx_descriptors_refill_t > > recycle_rx_descriptors_refill; > > > > > + uintptr_t reserved1[2]; > > > > > /**@}*/ > > > > > > > > > > /**@{*/ > > > > > @@ -99,15 +108,17 @@ struct rte_eth_fp_ops { > > > > > * Tx fast-path functions and related data. > > > > > * 64-bit systems: occupies second 64B line > > > > > */ > > > > > + /** Tx queues data. */ > > > > > + struct rte_ethdev_qdata txq; > > > > > /** PMD transmit function. */ > > > > > eth_tx_burst_t tx_pkt_burst; > > > > > /** PMD transmit prepare function. */ > > > > > eth_tx_prep_t tx_pkt_prepare; > > > > > /** Check the status of a Tx descriptor. */ > > > > > eth_tx_descriptor_status_t tx_descriptor_status; > > > > > - /** Tx queues data. */ > > > > > - struct rte_ethdev_qdata txq; > > > > > - uintptr_t reserved2[3]; > > > > > + /** Copy used mbufs from Tx mbuf ring into Rx. */ > > > > > + eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse; > > > > > + uintptr_t reserved2[2]; > > > > > /**@}*/ > > > > > > > > Removing existing fields should be announced explicitly. > > > > > > Agreed. And the patch misses this. The "rxq" and "txq" fields are > > > not being > > removed, they are being moved up in the structures. Your comment about > > explicit mentioning still applies! > > > > > > If there's no time to wait for a new patch version from Feifei, > > > perhaps you > > improve the description while merging. > > > > If it's only moving fields, we can skip. >=20 > OK. Thank you for elaborating. >=20 > > The real change is the size of the reserved fields, so it looks > > acceptable without notice. >=20 > Agree. Sorry for my late. Agree with this change. And then, I will update a new ve= rsion of recycle mbufs mode for dpdk 23.11 >=20 > Thoughts for later: We should perhaps document that changing the size of > reserved fields is acceptable. And with that, if completely removing a re= served > field is also acceptable or not.