From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8F479424EE;
Mon, 4 Sep 2023 11:24:20 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1EADC402AF;
Mon, 4 Sep 2023 11:24:20 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
(mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84])
by mails.dpdk.org (Postfix) with ESMTP id 463A1400EF
for <dev@dpdk.org>; Mon, 4 Sep 2023 11:24:18 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=BSbow38/PmpEumnbPYyaxwALVydqynwoBqUa9Dh258trTL3fbPCMxaGKLPIOb9fO2pqmn7VIOo8wHVz+sxNv6qxgIrgb9NrTgh3yLLzcS9egtNwrdV3AoQLAtQRk6kxDPD4ChGMdQ5j69DefPNoIXU+f2iopZZA08iPOWJetG/9he2Y8EWf1oiw8arHQ9feo860rfpi9kTuZBXt20PPeYILGGT/gbMu1leFneXo+F8uBBu9/dw4xN/V05Tsz9eU4k7QaJlowbsN22I7+31/AA4KZTmkoObmb85kGUGMXRQAZjjtmg57boFuucd4wBzLx4rlH+cBTX7Z4XETJhBFigw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=OrcT0uMQP/pNuB9CFvdPJjF8zNlKdq92s6lqga5P/gc=;
b=ILXp5KHDVeMVA4+UwMKOghzyLpWMwEtsPlCN/LP7f6z4o+wJ5rk90IaCULQ5K4Xjzex26QS1rxX+1ei6oVC1dC/AOCFM4EPdVOaB+oPN/gU+k/gNJOw8TLBTjEdf3VMYHj6xvOv2pba4tgX1cs8QVgldOu0ouiHKLiUU0s5V7dfQWbzU3lcL2fJ1MTnI6YUdbbMMdd+XeMEPFaRTHpTObYpx3V5u8fgBgvBbKa/jRUv1i5DmnJtdyIAOqGZYpbTjQ3iFThfw3dHyA9sfSpIqCAGyiIHqZfX5B9hQgOaLZuQx57iQJU+Lxc/GR9DYibPReb7CKIe28Kk5XXgIe+ME3A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=OrcT0uMQP/pNuB9CFvdPJjF8zNlKdq92s6lqga5P/gc=;
b=xjNQkk+tSIAzPDnKbn16uAoTrBYkPITrtNDwHrfs3VMt7id11L9/IUr/WeJwKAHzaIHBER24qvXa8A6S4f9WY4wHwj4tEbD62l7oh0yszoIzFlhaE+u3PVD4YoXfQWtOzJkaSK74UFxyIltQrA6ew9mZv3Ias27DfQr3SX/Sc3k=
Received: from AS8PR08MB7718.eurprd08.prod.outlook.com (2603:10a6:20b:50a::22)
by PA4PR08MB5902.eurprd08.prod.outlook.com (2603:10a6:102:e0::10)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.28; Mon, 4 Sep
2023 09:24:16 +0000
Received: from AS8PR08MB7718.eurprd08.prod.outlook.com
([fe80::5530:2382:34ac:cb8e]) by AS8PR08MB7718.eurprd08.prod.outlook.com
([fe80::5530:2382:34ac:cb8e%4]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023
09:24:16 +0000
From: Feifei Wang <Feifei.Wang2@arm.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>, Konstantin Ananyev
<konstantin.v.ananyev@yandex.ru>
CC: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, Yuying
Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, nd
<nd@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
Thread-Topic: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
Thread-Index: AQHZ1Mog0nujzlh9U0CHKeg6D9zv8K/48qdwgAvD0gCAARCtoIAATscAgAQvdqCAABm6gIAAGI7g
Date: Mon, 4 Sep 2023 09:24:15 +0000
Message-ID: <AS8PR08MB771835A3AA7841DEF38ADB1FC8E9A@AS8PR08MB7718.eurprd08.prod.outlook.com>
References: <20220420081650.2043183-1-feifei.wang2@arm.com>
<20230822072710.1945027-1-feifei.wang2@arm.com>
<20230822072710.1945027-3-feifei.wang2@arm.com>
<AS8PR08MB77189BD70AD1E420E4D05E2EC81DA@AS8PR08MB7718.eurprd08.prod.outlook.com>
<f330a818868c40d6a4547b7a01e7a93e@huawei.com>
<AS8PR08MB77189E20819A012F2D6FDCC2C8E4A@AS8PR08MB7718.eurprd08.prod.outlook.com>
<6e3a2b3f24e046358646fa26e19122d0@huawei.com>
<AS8PR08MB7718C6C3D8A7574EE603E86AC8E9A@AS8PR08MB7718.eurprd08.prod.outlook.com>
<09ffb5499f594fa4a5f7312a3c6fb5cd@huawei.com>
In-Reply-To: <09ffb5499f594fa4a5f7312a3c6fb5cd@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: A9A6C5A41DCE68489425E86F74962C72.0
x-checkrecipientchecked: true
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: AS8PR08MB7718:EE_|PA4PR08MB5902:EE_
x-ms-office365-filtering-correlation-id: 6153d58a-bb05-4d84-0a69-08dbad28b598
nodisclaimer: true
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: TNR05RXbC1CvMFLM8MpElGRN3ru9I8xfQSTPl+lsMnU/3lkolHDTYu5/+pvJSQPxQ+ZZq0+obLjH4OMarKTTK3FMBdf04KMlvUy4F7MYh72Ur6CVsIgBXQA2YscbSs0joL6gcpZEU9RhAyXbOOwyLUeV90UJ6i3y2kE5GFz5FFXoklDGxlzlH6GIzYPFRUuccrGLNXd8+OFHzeVFvNCxb7pqxf7cjYfrDcXmvqXc4AUWmtJO8BiZ5cSJCQm0sgI0dDkZkO8nvGocJ2jsjgIcDHW3+bcc0H7i0TvERZ2dL2XsglRTqZhNDD5oaop+0ZsNm5KUY9Lk5LVDF8eahRPHYogrlv4nKotjHQtd38SFUxGoVNyje9QkwQO9ehKBnvMVTvrzq16OZmQ3PdpWHS1knYuoSc3QZq9saq+HMCEQewVOAL1PAQefqphLTYOygFwWyzdZrQ0opIOBXuS6xrr0tgK2nq/BNkbX7AQihDVPpEAUueNETUE0JJ8B1ZvpDy6nOFh5YlO9a7l/2N9NI4o9slbT5Pf5OPFJNxtoUnR9Mz2tZXlv6Yr0DeERIPAJpPB/AJu/K2hg7q36yqHzGaY2s8ja9xwJwucRS9qhgwg7PMmL3qgBh9skusbUoeqMfn59wwrorSs0/JFcqbQtdEkzJw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:AS8PR08MB7718.eurprd08.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199024)(186009)(1800799009)(26005)(71200400001)(55016003)(8936002)(8676002)(4326008)(52536014)(83380400001)(5660300002)(9686003)(53546011)(6506007)(7696005)(41300700001)(64756008)(478600001)(54906003)(110136005)(66446008)(66476007)(66946007)(66556008)(86362001)(33656002)(316002)(38070700005)(38100700002)(76116006)(2906002)(122000001)(30864003)(448954002)(579004);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r0XVONyF3KmrzOO1zMyk0c80Gy25Hyklyp0KklHSLjUVAcgPo8mA6t+Vq6ha?=
=?us-ascii?Q?4ZtDbAdnuOmVqpZkxSpEa1K7hGX3KSFwVipbBOPTv6f65L9WFW4jXyFTneey?=
=?us-ascii?Q?1YwWo5ngOBH3waveCZATB+7kqaqBYJmMrB6AFrbqh9QdFO5aI9nGhmHnxnNi?=
=?us-ascii?Q?LmgVpUyEGd7IznHyHjMMXzgsSsWtu/TXFKIxtTzZnxRyfcaca96eGeK+ELFI?=
=?us-ascii?Q?QLK3RlRek00yf6ykMNmGb0Klr+YQHUtOaMS6U7hoOE1leWpu0cZjRmYHoCaf?=
=?us-ascii?Q?J8+OhJYRutUx4WRx6CZKB1ZpsoxUQr3uT3SjRHO0Kw5OYrc6UktVN8sNbDVK?=
=?us-ascii?Q?x3VrspwNVnKjyT09tuFMbkl46+cE3gdF4RpB/6mNHeOPei5BdJqkWHLG9dbh?=
=?us-ascii?Q?h3QQMPcyI4bDUZwtDJ7okeIENP2v/RKl2rg4RTC+rPTKnELbsYxf6txZnUE/?=
=?us-ascii?Q?Z14I0Vi3+mETj44GQHzFTypF4ckA5cjdyAgDpg+wC+CCzSrNiokWFiEEGKOl?=
=?us-ascii?Q?c1UHo6JmqcEXvWUxg616mcBah5tm0j94+YX63KSWgZJYqfgTmJgjRAknSENJ?=
=?us-ascii?Q?fS+QEVdpQC/e14+N8Ilajsfk0HCptvhkA8fZwfRl81XqeAr8D99x0ELk0UA7?=
=?us-ascii?Q?X1vd4Pj6NmZC9T7TfjiuCUVhmjKUSUnHgBZeLL9H8DBVtnELirmE8rQyDelY?=
=?us-ascii?Q?9O+AYtDUtT3T1z6zxrFrJTrs657K2opCw8J/nJOviHcYLV3NPlo3dYHBeZDt?=
=?us-ascii?Q?Ut32RWO61EXuj1hdqIJ5h4OFEjOAI5dVoMEHkeNJlAW71wgaht1d7p5THb71?=
=?us-ascii?Q?m/agxStExUtbZFjgcOatKNSl7/zPDXm1RfoaMRl7eQMua5eftlbwrVIP70ue?=
=?us-ascii?Q?zPGqlNxrsfgWMDAHLCKHtvohZa9FTAkUXfx+09DH0VcW6SXhx/z16Oe6VleM?=
=?us-ascii?Q?R8OiTDKD3qF2rz+Csb4/HpKYYaKZ5TpyWnqrtS4rL/LuTkD9Q3bQifPFrOW8?=
=?us-ascii?Q?aIH/Mj5R+GWpqg1CtVVtyqhLDq7iQH/8YjbJuzfvnb7HX6VU/8wGqqJNwO41?=
=?us-ascii?Q?UwdYBKmZqTWYmnLF/IEHvuxzkmW6dc3ptyqAPsQw1H53s/Dn8c+ZUS2r9z+E?=
=?us-ascii?Q?L4+LCEpu4VRbEsIpOGatu2exiRl4Yq1XlHGcn8tXuSxVoQdTK2G8zLlrmsHz?=
=?us-ascii?Q?VYQ/q/l8CLildFb1bk1mXTaaCnQarthZhsQBdJbBCIWffkFcEJLKAZyFaGYh?=
=?us-ascii?Q?IvcLEM2w+b7VLfloJ+WTXTixSxY6h5d12K+VTL95+qGC5WHVp5ZAlleK8+zL?=
=?us-ascii?Q?MjudKhiVvyiJEtdsvzOvnBOaY0J28mjgAYdbWuVZFdX+6IYu7L1bQ0QBJHr1?=
=?us-ascii?Q?KpLHIK6I38WIvenIREZj60e79F7FoNDsePeWAJiNYHctKqluNE4JckykUlCb?=
=?us-ascii?Q?BtsMcMWfcZYW2DXWHBttaeymb+oX0FbNBLPbqILPrFUz6vremDMzte4tYUgM?=
=?us-ascii?Q?3s8FQrPh4xYeEu0Xn4YbyA5OILsu2pzC0vBW7PgDEunyrhX9Mw6LROjuFrwB?=
=?us-ascii?Q?4JGANP1w9ZzdaFPtFWDXcMWcCWvxoFZIVxHlpvWk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7718.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6153d58a-bb05-4d84-0a69-08dbad28b598
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2023 09:24:15.9970 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i0aG688JXenj2tA0quzBUZPoPkWSk5hOM8V4vZTAubpqzVLzMFbNO9QkrHKh1loQ9zVNeDMoldTxcdpA2QT+uQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5902
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> -----Original Message-----
> From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Sent: Monday, September 4, 2023 3:50 PM
> To: Feifei Wang <Feifei.Wang2@arm.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Yuying Zhang <Yuying.Zhang@intel.com>; Beilei
> Xing <beilei.xing@intel.com>; nd <nd@arm.com>; nd <nd@arm.com>; nd
> <nd@arm.com>
> Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
>=20
>=20
> Hi Feifei,
>=20
> > > > > > > Define specific function implementation for i40e driver.
> > > > > > > Currently, mbufs recycle mode can support 128bit vector path
> > > > > > > and
> > > > > > > avx2
> > > > > path.
> > > > > > > And can be enabled both in fast free and no fast free mode.
> > > > > > >
> > > > > > > Suggested-by: Honnappa Nagarahalli
> > > > > > > <honnappa.nagarahalli@arm.com>
> > > > > > > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > > > > > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > > > > > > Reviewed-by: Honnappa Nagarahalli
> > > <honnappa.nagarahalli@arm.com>
> > > > > > > ---
> > > > > > > drivers/net/i40e/i40e_ethdev.c | 1 +
> > > > > > > drivers/net/i40e/i40e_ethdev.h | 2 +
> > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c | 147
> > > > > > > ++++++++++++++++++
> > > > > > > drivers/net/i40e/i40e_rxtx.c | 32 ++++
> > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 +
> > > > > > > drivers/net/i40e/meson.build | 1 +
> > > > > > > 6 files changed, 187 insertions(+) create mode 100644
> > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > >
> > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > 8271bbb394..50ba9aac94
> > > > > > > 100644
> > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > @@ -496,6 +496,7 @@ static const struct eth_dev_ops
> > > > > > > i40e_eth_dev_ops
> > > > > =3D {
> > > > > > > .flow_ops_get =3D i40e_dev_flow_ops_get,
> > > > > > > .rxq_info_get =3D i40e_rxq_info_get,
> > > > > > > .txq_info_get =3D i40e_txq_info_get,
> > > > > > > + .recycle_rxq_info_get =3D i40e_recycle_rxq_info_get=
,
> > > > > > > .rx_burst_mode_get =3D i40e_rx_burst_mode_get,
> > > > > > > .tx_burst_mode_get =3D i40e_tx_burst_mode_get,
> > > > > > > .timesync_enable =3D i40e_timesync_enable,
> > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > b/drivers/net/i40e/i40e_ethdev.h index
> > > > > > > 6f65d5e0ac..af758798e1
> > > > > > > 100644
> > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > > > > > @@ -1355,6 +1355,8 @@ void i40e_rxq_info_get(struct
> > > > > > > rte_eth_dev *dev, uint16_t queue_id,
> > > > > > > struct rte_eth_rxq_info *qinfo); void
> > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
> > > > > > > struct rte_eth_txq_info *qinfo);
> > > > > > > +void i40e_recycle_rxq_info_get(struct rte_eth_dev *dev,
> > > > > > > +uint16_t
> > > > > queue_id,
> > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info);
> > > > > > > int i40e_rx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > uint16_t
> > > queue_id,
> > > > > > > struct rte_eth_burst_mode *mode); int
> > > > > > > i40e_tx_burst_mode_get(struct rte_eth_dev *dev, uint16_t
> > > > > > > queue_id, diff -- git
> > > > > > > a/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > new file mode 100644
> > > > > > > index 0000000000..5663ecccde
> > > > > > > --- /dev/null
> > > > > > > +++ b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > @@ -0,0 +1,147 @@
> > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > > > > > + * Copyright (c) 2023 Arm Limited.
> > > > > > > + */
> > > > > > > +
> > > > > > > +#include <stdint.h>
> > > > > > > +#include <ethdev_driver.h>
> > > > > > > +
> > > > > > > +#include "base/i40e_prototype.h"
> > > > > > > +#include "base/i40e_type.h"
> > > > > > > +#include "i40e_ethdev.h"
> > > > > > > +#include "i40e_rxtx.h"
> > > > > > > +
> > > > > > > +#pragma GCC diagnostic ignored "-Wcast-qual"
> > > > > > > +
> > > > > > > +void
> > > > > > > +i40e_recycle_rx_descriptors_refill_vec(void *rx_queue,
> > > > > > > +uint16_t
> > > > > > > +nb_mbufs) {
> > > > > > > + struct i40e_rx_queue *rxq =3D rx_queue;
> > > > > > > + struct i40e_rx_entry *rxep;
> > > > > > > + volatile union i40e_rx_desc *rxdp;
> > > > > > > + uint16_t rx_id;
> > > > > > > + uint64_t paddr;
> > > > > > > + uint64_t dma_addr;
> > > > > > > + uint16_t i;
> > > > > > > +
> > > > > > > + rxdp =3D rxq->rx_ring + rxq->rxrearm_start;
> > > > > > > + rxep =3D &rxq->sw_ring[rxq->rxrearm_start];
> > > > > > > +
> > > > > > > + for (i =3D 0; i < nb_mbufs; i++) {
> > > > > > > + /* Initialize rxdp descs. */
> > > > > > > + paddr =3D (rxep[i].mbuf)->buf_iova +
> > > > > > > RTE_PKTMBUF_HEADROOM;
> > > > > > > + dma_addr =3D rte_cpu_to_le_64(paddr);
> > > > > > > + /* flush desc with pa dma_addr */
> > > > > > > + rxdp[i].read.hdr_addr =3D 0;
> > > > > > > + rxdp[i].read.pkt_addr =3D dma_addr;
> > > > > > > + }
> > > > > > > +
> > > > > > > + /* Update the descriptor initializer index */
> > > > > > > + rxq->rxrearm_start +=3D nb_mbufs;
> > > > > > > + rx_id =3D rxq->rxrearm_start - 1;
> > > > > > > +
> > > > > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) {
> > > > > > > + rxq->rxrearm_start =3D 0;
> > > > > > > + rx_id =3D rxq->nb_rx_desc - 1;
> > > > > > > + }
> > > > > > > +
> > > > > > > + rxq->rxrearm_nb -=3D nb_mbufs;
> > > > > > > +
> > > > > > > + rte_io_wmb();
> > > > > > > + /* Update the tail pointer on the NIC */
> > > > > > > + I40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id); }
> > > > > > > +
> > > > > > > +uint16_t
> > > > > > > +i40e_recycle_tx_mbufs_reuse_vec(void *tx_queue,
> > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info) {
> > > > > > > + struct i40e_tx_queue *txq =3D tx_queue;
> > > > > > > + struct i40e_tx_entry *txep;
> > > > > > > + struct rte_mbuf **rxep;
> > > > > > > + int i, n;
> > > > > > > + uint16_t nb_recycle_mbufs;
> > > > > > > + uint16_t avail =3D 0;
> > > > > > > + uint16_t mbuf_ring_size =3D recycle_rxq_info->mbuf_ring_siz=
e;
> > > > > > > + uint16_t mask =3D recycle_rxq_info->mbuf_ring_size - 1;
> > > > > > > + uint16_t refill_requirement =3D recycle_rxq_info-
> > > >refill_requirement;
> > > > > > > + uint16_t refill_head =3D *recycle_rxq_info->refill_head;
> > > > > > > + uint16_t receive_tail =3D *recycle_rxq_info->receive_tail;
> > > > > > > +
> > > > > > > + /* Get available recycling Rx buffers. */
> > > > > > > + avail =3D (mbuf_ring_size - (refill_head - receive_tail)) &
> > > > > > > +mask;
> > > > > > > +
> > > > > > > + /* Check Tx free thresh and Rx available space. */
> > > > > > > + if (txq->nb_tx_free > txq->tx_free_thresh || avail <=3D txq=
-
> > > >tx_rs_thresh)
> > > > > > > + return 0;
> > > > > > > +
> > > > > > > + /* check DD bits on threshold descriptor */
> > > > > > > + if ((txq->tx_ring[txq->tx_next_dd].cmd_type_offset_bsz &
> > > > > > > +
> > > > > > > rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) !=3D
> > > > > > > +
> > > > > > > rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))
> > > > > > > + return 0;
> > > > > > > +
> > > > > > > + n =3D txq->tx_rs_thresh;
> > > > > > > + nb_recycle_mbufs =3D n;
> > > > > > > +
> > > > > > > + /* Mbufs recycle mode can only support no ring buffer
> > > wrapping
> > > > > > > around.
> > > > > > > + * Two case for this:
> > > > > > > + *
> > > > > > > + * case 1: The refill head of Rx buffer ring needs to be
> > > > > > > +aligned
> > > with
> > > > > > > + * mbuf ring size. In this case, the number of Tx freeing b=
uffers
> > > > > > > + * should be equal to refill_requirement.
> > > > > > > + *
> > > > > > > + * case 2: The refill head of Rx ring buffer does not need
> > > > > > > +to be
> > > aligned
> > > > > > > + * with mbuf ring size. In this case, the update of refill
> > > > > > > +head
> > > can not
> > > > > > > + * exceed the Rx mbuf ring size.
> > > > > > > + */
> > > > > > > + if (refill_requirement !=3D n ||
> > > > > > > + (!refill_requirement && (refill_head + n >
> > > mbuf_ring_size)))
> > > > > > > + return 0;
> > > > > > > +
> > > > > > > + /* First buffer to free from S/W ring is at index
> > > > > > > + * tx_next_dd - (tx_rs_thresh-1).
> > > > > > > + */
> > > > > > > + txep =3D &txq->sw_ring[txq->tx_next_dd - (n - 1)];
> > > > > > > + rxep =3D recycle_rxq_info->mbuf_ring;
> > > > > > > + rxep +=3D refill_head;
> > > > > > > +
> > > > > > > + if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
> > > > > > > + /* Avoid txq contains buffers from unexpected
> > > mempool. */
> > > > > > > + if (unlikely(recycle_rxq_info->mp
> > > > > > > + !=3D txep[0].mbuf->pool))
> > > > > > > + return 0;
> > > > > > > +
> > > > > > > + /* Directly put mbufs from Tx to Rx. */
> > > > > > > + for (i =3D 0; i < n; i++)
> > > > > > > + rxep[i] =3D txep[i].mbuf;
> > > > > > > + } else {
> > > > > > > + for (i =3D 0; i < n; i++) {
> > > > > > > + rxep[i] =3D
> > > rte_pktmbuf_prefree_seg(txep[i].mbuf);
> > > > > > > +
> > > > > > > + /* If Tx buffers are not the last reference or
> > > from
> > > > > > > + * unexpected mempool, previous copied
> > > buffers are
> > > > > > > + * considered as invalid.
> > > > > > > + */
> > > > > > > + if (unlikely((rxep[i] =3D=3D NULL &&
> > > refill_requirement) ||
> > > > > > [Konstantin]
> > > > > > Could you pls remind me why it is ok to have rxep[i]=3D=3DNULL
> > > > > > when refill_requirement is not set?
> > > > > >
> > > > > > If reill_requirement is not zero, it means each tx freed
> > > > > > buffer must be valid and can be put into Rx sw_ring. Then the
> > > > > > refill head of Rx buffer ring can be aligned with mbuf ring
> > > > > > size. Briefly speaking the number
> > > > > of Tx valid freed buffer must be equal to Rx refill_requirement.
> > > > > For example, i40e driver.
> > > > > >
> > > > > > If reill_requirement is zero, it means that the refill head of
> > > > > > Rx buffer ring does not need to be aligned with mbuf ring
> > > > > > size, thus if Tx have n valid freed buffers, we just need to
> > > > > > put these n buffers into Rx sw-
> > > > > ring, and not to be equal to the Rx setting rearm number. For
> > > > > example, mlx5 driver.
> > > > > >
> > > > > > In conclusion, above difference is due to pmd drivers have
> > > > > > different
> > > > > strategies to update their Rx rearm(refill) head.
> > > > > > For i40e driver, if rearm_head exceed 1024, it will be set as
> > > > > > 0 due to the
> > > > > number of each rearm is a fixed value by default.
> > > > > > For mlx5 driver. Its rearm_head can exceed 1024, and use mask
> > > > > > to achieve
> > > > > real index. Thus its rearm number can be a different value.
> > > > >
> > > > > Ok, but if rte_pktmbuf_prefree_seg(txep[i].mbuf), it means that
> > > > > this mbuf is not free yet and can't be reused.
> > > > > Shouldn't we then set nb_recycle_mbufs =3D 0 in that case too?
> > > > > Or probably would be enough to skip that mbuf?
> > > > > Might be something like that:
> > > > >
> > > > > for (i =3D 0, j =3D 0; i < n; i++) {
> > > > >
> > > > > rxep[j] =3D rte_pktmbuf_prefree_seg(txep[i].mbuf);
> > > > > if (rxep[j] =3D=3D NULL || recycle_rxq_info->mp !=3D rxep[j].mbu=
f->pool)) {
> > > > > if (refill_requirement) {
> > > > > nb_recycle_mbufs =3D 0;
> > > > > break;
> > > > > }
> > > > > } else
> > > > > j++;
> > > > > }
> > > > >
> > > > > /* now j contains actual number of recycled mbufs */
> > > > >
> > > > > ?
> > > > >
> > > > > >
> > > > > > > + recycle_rxq_info->mp !=3D
> > > txep[i].mbuf-
> > > > > > > >pool))
> > > > > > > + nb_recycle_mbufs =3D 0;
> > > > > > > + }
> > > > > > > + /* If Tx buffers are not the last reference or
> > > > > > > + * from unexpected mempool, all recycled buffers
> > > > > > > + * are put into mempool.
> > > > > > > + */
> > > > > > > + if (nb_recycle_mbufs =3D=3D 0)
> > > > > > > + for (i =3D 0; i < n; i++) {
> > > > > > > + if (rxep[i] !=3D NULL)
> > > > > > > + rte_mempool_put(rxep[i]-
> > > >pool,
> > > > > > > rxep[i]);
> > > > > > > + }
> > > > > > > + }
> > > > > > > +
> > > > [Konstantin] After another thought, it might be easier and cleaner =
just to:
> > > > if (rxep[j] =3D=3D NULL || recycle_rxq_info->mp !=3D rxep[j].mbuf->=
pool)
> > > > nb_recycle_mbufs =3D 0;
> > > >
> > > > Anyway, from my understanding - if rte_pktmbuf_prefree_seg(mbuf)
> > > > returns NULL, then we can't recycle that mbuf.
> > > >
> > > > [Feifei] Agree with that 'rte_pktmbuf_prefree_seg(mbuf) returns
> > > > NULL, then
> > > we can't recycle that mbuf'.
> > > >
> > > > Firstly, we should know for i40e driver, the number of free mbufs
> > > > is fixed, it
> > > must equal to 'tx_rs_thresh'
> > > > This means if we start to free Tx mbufs, it cannot be interrupted
> > > > until the
> > > given amount of mbufs are freed.
> > > > In the meanwhile, doing prefree operation for a Tx mbuf can be
> > > > looked at this mbuf is freed from this TX sw-ring if the API
> > > > returns NULL. This is due
> > > to that call 'prefree_seg' function means update the mbuf refcnt.
> > > >
> > > > So let's come back our recycle mbuf case.
> > > > Here we consider that the case if we have 32 mbufs need to be
> > > > freed, and
> > > we firstly do the pre-free.
> > > > And then first 8 mbufs is good and return value is not none. But
> > > > the 9th
> > > mbuf is bad, its refcnt is more than 1.
> > > > So we just update its refcnt and cannot put it into Rx sw-ring.
> > > > For Tx sw-ring,
> > > this mbuf has been freed.
> > > > Then we should continue to do pre-free operation for the next Tx
> > > > mbufs to ensure the given amount of mbufs are freed.
> > > >
> > > > Do a conclusion for this, this is because if we start to do
> > > > pre-free operation, the Tx mbuf refcnt value maybe changed, so we
> > > > cannot stop or
> > > break until finish all the pre-free operation.
> > > >
> > > > Finally, in the case that Rx refill_request is not zero, but the
> > > > valid mbuf amount is less than this value, we must put back this
> > > > Tx mbufs into
> > > mempool.
> > > >
> > > > Above is the reason why I do not directly jump out of the loop if
> > > > some mbuf
> > > return value is NULL.
> > >
> > > Yep, I already realized that it is a bit more complicated and we
> > > need to continue with prefree() for all packets even when we get NULL=
in
> the middle.
> > > Anyway the code has to be changed, right?
> > >
> > Sorry, I think for the code, it is unnecessary to be changed.
> > For no fast free path, currently:
> > 1. We check whether each mbuf is Ok and call pre_free function
> > ----------------------------------------------------------------------
> > --------------------------------------------------------------
> > 2.1 For the mbuf return value is not NULL, it is put into Rx sw-ring.
> > 2.2 For the mbuf return value is zero and refill-request, it will also
> > firstly put into Rx sw-ring, and we set nb_recycle =3D 0
> > ----------------------------------------------------------------------
> > --------------------------------------------------------------
> > 3.1 We check nb_recycle, if it is not 0, we will continue to rearm Rx d=
escs
> and update its index by call descs_refill function.
> > 3.2 if nb_recycle is 0, we will put valid recycle mbufs back into
> > mempool as general path. This is necessary, because we need to ensure
> > the freed Tx number is fixed.(Some buffers return is null can be seen
> > as freed, others need to be put into mempool)
> >
> > Or maybe I ignore something?
>=20
>=20
> I am talking about the case when both refill_requirement and mbuf return
> values iare zero:
> if (unlikely((rxep[i] =3D=3D NULL && refill_requirement) || // ??=
? rxep[i] =3D=3D 0
> AND refill_requirement =3D=3D 0 ???
> recycle_rxq_info->mp !=3D txep[i].mbuf->pool))
> nb_recycle_mbufs =3D 0;
>=20
> As I can read the code you treat such situation as valid, while I think w=
e
> should reset nb_recycle_mbufs to zero when rxep[i] =3D=3D NULL, no matter=
what
> value refill_requirement is.
So this means for maybe MLX5 driver, its refill_request =3D 0. And if some =
mbufs return value
is zero, the other mbufs can not be recycled into Rx sw-ring? Because nb_re=
cycle=3D0, and they
need to be put into mempool.
I think for such as MLX5 driver, we can allow recycle some valid mbufs into=
Rx ring.=20
Because no constraint for its refill number. Is my suggestion reasonable?=20
> .
>=20
>=20
> > > >
> > > > > > > + /* Update counters for Tx. */
> > > > > > > + txq->nb_tx_free =3D (uint16_t)(txq->nb_tx_free + txq-
> > > >tx_rs_thresh);
> > > > > > > + txq->tx_next_dd =3D (uint16_t)(txq->tx_next_dd + txq-
> > > >tx_rs_thresh);
> > > > > > > + if (txq->tx_next_dd >=3D txq->nb_tx_desc)
> > > > > > > + txq->tx_next_dd =3D (uint16_t)(txq->tx_rs_thresh - 1);
> > > > > > > +
> > > > > > > + return nb_recycle_mbufs;
> > > > > > > +}
> > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c
> > > > > > > b/drivers/net/i40e/i40e_rxtx.c index b4f65b58fa..a9c9eb331c
> > > > > > > 100644
> > > > > > > --- a/drivers/net/i40e/i40e_rxtx.c
> > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.c
> > > > > > > @@ -3199,6 +3199,30 @@ i40e_txq_info_get(struct rte_eth_dev
> > > > > > > *dev, uint16_t queue_id,
> > > > > > > qinfo->conf.offloads =3D txq->offloads; }
> > > > > > >
> > > > > > > +void
> > > > > > > +i40e_recycle_rxq_info_get(struct rte_eth_dev *dev, uint16_t
> > > queue_id,
> > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info) {
> > > > > > > + struct i40e_rx_queue *rxq;
> > > > > > > + struct i40e_adapter *ad =3D
> > > > > > > + I40E_DEV_PRIVATE_TO_ADAPTER(dev->data-
> > > >dev_private);
> > > > > > > +
> > > > > > > + rxq =3D dev->data->rx_queues[queue_id];
> > > > > > > +
> > > > > > > + recycle_rxq_info->mbuf_ring =3D (void *)rxq->sw_ring;
> > > > > > > + recycle_rxq_info->mp =3D rxq->mp;
> > > > > > > + recycle_rxq_info->mbuf_ring_size =3D rxq->nb_rx_desc;
> > > > > > > + recycle_rxq_info->receive_tail =3D &rxq->rx_tail;
> > > > > > > +
> > > > > > > + if (ad->rx_vec_allowed) {
> > > > > > > + recycle_rxq_info->refill_requirement =3D
> > > > > > > RTE_I40E_RXQ_REARM_THRESH;
> > > > > > > + recycle_rxq_info->refill_head =3D &rxq->rxrearm_start;
> > > > > > > + } else {
> > > > > > > + recycle_rxq_info->refill_requirement =3D rxq-
> > > >rx_free_thresh;
> > > > > > > + recycle_rxq_info->refill_head =3D &rxq->rx_free_trigger;
> > > > > > > + }
> > > > > > > +}
> > > > > > > +
> > > > > > > #ifdef RTE_ARCH_X86
> > > > > > > static inline bool
> > > > > > > get_avx_supported(bool request_avx512) @@ -3293,6 +3317,8
> @@
> > > > > > > i40e_set_rx_function(struct rte_eth_dev *dev)
> > > > > > > dev->rx_pkt_burst =3D ad-
> >rx_use_avx2 ?
> > > > > > >
> i40e_recv_scattered_pkts_vec_avx2 :
> > > > > > > i40e_recv_scattered_pkts_vec;
> > > > > > > + dev->recycle_rx_descriptors_refill =3D
> > > > > > > +
> > > i40e_recycle_rx_descriptors_refill_vec;
> > > > > > > }
> > > > > > > } else {
> > > > > > > if (ad->rx_use_avx512) {
> > > > > > > @@ -3311,9 +3337,12 @@ i40e_set_rx_function(struct rte_eth_de=
v
> > > *dev)
> > > > > > > dev->rx_pkt_burst =3D ad-
> >rx_use_avx2 ?
> > > > > > > i40e_recv_pkts_vec_avx2 :
> > > > > > > i40e_recv_pkts_vec;
> > > > > > > + dev->recycle_rx_descriptors_refill =3D
> > > > > > > +
> > > i40e_recycle_rx_descriptors_refill_vec;
> > > > > > > }
> > > > > > > }
> > > > > > > #else /* RTE_ARCH_X86 */
> > > > > > > + dev->recycle_rx_descriptors_refill =3D
> > > > > > > +i40e_recycle_rx_descriptors_refill_vec;
> > > > > > > if (dev->data->scattered_rx) {
> > > > > > > PMD_INIT_LOG(DEBUG,
> > > > > > > "Using Vector Scattered Rx
> (port %d).", @@
> > > > > > > -3481,15 +3510,18 @@ i40e_set_tx_function(struct rte_eth_dev
> *dev)
> > > > > > > dev->tx_pkt_burst =3D ad-
> >tx_use_avx2 ?
> > > > > > >
> i40e_xmit_pkts_vec_avx2 :
> > > > > > >
> i40e_xmit_pkts_vec;
> > > > > > > + dev->recycle_tx_mbufs_reuse =3D
> > > > > > > i40e_recycle_tx_mbufs_reuse_vec;
> > > > > > > }
> > > > > > > #else /* RTE_ARCH_X86 */
> > > > > > > PMD_INIT_LOG(DEBUG, "Using Vector Tx
> (port %d).",
> > > > > > > dev->data->port_id);
> > > > > > > dev->tx_pkt_burst =3D i40e_xmit_pkts_vec;
> > > > > > > + dev->recycle_tx_mbufs_reuse =3D
> > > > > > > i40e_recycle_tx_mbufs_reuse_vec; #endif /* RTE_ARCH_X86 */
> > > > > > > } else {
> > > > > > > PMD_INIT_LOG(DEBUG, "Simple tx finally be
> used.");
> > > > > > > dev->tx_pkt_burst =3D i40e_xmit_pkts_simple;
> > > > > > > + dev->recycle_tx_mbufs_reuse =3D
> > > > > > > i40e_recycle_tx_mbufs_reuse_vec;
> > > > > > > }
> > > > > > > dev->tx_pkt_prepare =3D i40e_simple_prep_pkts;
> > > > > > > } else {
> > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.h
> > > > > > > b/drivers/net/i40e/i40e_rxtx.h index a8686224e5..b191f23e1f
> > > > > > > 100644
> > > > > > > --- a/drivers/net/i40e/i40e_rxtx.h
> > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.h
> > > > > > > @@ -236,6 +236,10 @@ uint32_t i40e_dev_rx_queue_count(void
> > > > > > > *rx_queue); int i40e_dev_rx_descriptor_status(void *rx_queue=
,
> > > > > > > uint16_t offset); int i40e_dev_tx_descriptor_status(void
> > > > > > > *tx_queue, uint16_t offset);
> > > > > > >
> > > > > > > +uint16_t i40e_recycle_tx_mbufs_reuse_vec(void *tx_queue,
> > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info);
> > > void
> > > > > > > +i40e_recycle_rx_descriptors_refill_vec(void *rx_queue, uint1=
6_t
> > > > > > > +nb_mbufs);
> > > > > > > +
> > > > > > > uint16_t i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> > > **rx_pkts,
> > > > > > > uint16_t nb_pkts);
> > > > > > > uint16_t i40e_recv_scattered_pkts_vec(void *rx_queue, diff
> > > > > > > --git a/drivers/net/i40e/meson.build
> > > > > > > b/drivers/net/i40e/meson.build index
> > > > > > > 8e53b87a65..3b1a233c84 100644
> > > > > > > --- a/drivers/net/i40e/meson.build
> > > > > > > +++ b/drivers/net/i40e/meson.build
> > > > > > > @@ -34,6 +34,7 @@ sources =3D files(
> > > > > > > 'i40e_tm.c',
> > > > > > > 'i40e_hash.c',
> > > > > > > 'i40e_vf_representor.c',
> > > > > > > + 'i40e_recycle_mbufs_vec_common.c',
> > > > > > > 'rte_pmd_i40e.c',
> > > > > > > )
> > > > > > >
> > > > > > > --
> > > > > > > 2.25.1