From: Константин Ананьев <konstantin.v.ananyev@yandex.ru>
Sent: Monday, June 5, 2023 9:08 PM
To: Feifei Wang <Feifei.Wang2@arm.com>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>
Cc: dev@dpdk.org; nd <nd@arm.com>; Jerin Jacob <jerinjacobk@gmail.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>
Subject: Re: [PATCH v6 4/4] app/testpmd: add recycle mbufs engine

[…]

+static void
+recycle_mbufs_stream_init(struct fwd_stream *fs)
+{
+ /* Retrieve information about given ports's Rx queue
+ * for recycling mbufs.
+ */
+ rte_eth_recycle_rx_queue_info_get(fs->rx_port, fs->rx_queue,
+ &(fs->recycle_rxq_info));

[Konstantin] We probably should check the return status and complain about failure.

[Feifei]  Agree. However, testpmd ‘stream_init’ function return value is void. Here,

If errors happen, what we can do is to only complain about failure.