From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4D08C69C6 for ; Wed, 22 Mar 2017 15:23:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490192582; x=1521728582; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=J5Vxj+sfYWeB8AiIspeXTcQ97QK4QV0fj47TZ9g0gnU=; b=aVj3bYeZzJJgVbX+fomaS9G+rrx03FWD9gcsLIelYUVZYpQzvxWN1yLq kNHg8ruvbPl/60nLUqb6ep3CxW3mMQ==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 07:23:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="79417971" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 22 Mar 2017 07:23:00 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 07:23:00 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.175]) by fmsmsx120.amr.corp.intel.com ([169.254.15.227]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 07:23:00 -0700 From: "Wiles, Keith" To: Pascal Mazon CC: "dev@dpdk.org" Thread-Topic: [PATCH v6 0/4] net/tap: support flow API Thread-Index: AQHSovGE60UCKX4gNEiUcGtUSC8SzKGhXxEA Date: Wed, 22 Mar 2017 14:22:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.105] Content-Type: text/plain; charset="us-ascii" Content-ID: <20E3AE4191648B4EBE54DD5AE3683DCA@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 0/4] net/tap: support flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 14:23:03 -0000 > On Mar 22, 2017, at 4:48 AM, Pascal Mazon wrote: >=20 > This series add support for the flow API in tap PMD. >=20 > It enables filtering specific packets incoming on the tap netdevice, to > process only desired ones. Under the hood, it uses kernel TC (traffic > control), which takes place very early in the stack, and supports most > common pattern items and actions defined in the flow API. >=20 > v6 changes: > - fix compilation issue on i686 (wrong cast for rte flow handle) >=20 > v5 changes: > - rebase after adrien's patches on Tx poll and Rx signaling > - better spaces for comments in rte_eth_tap.h >=20 > v4 changes: > - rebase on top of "net/tap: add additional management ops" series > - fix a few netlink doxygen comments > - rename tap.h -> rte_eth_tap.h > - flush flow rules only when applicable >=20 > v3 changes: > - vlan patterns enabled depending on running kernel (4.9+) > - update doc/guides/nics/tap.rst for Flow API support > - rebase on top of "net/tap: add additional management ops" series >=20 > v2 changes: > - support compilation on kernels < 4.2 (where flower support appeared) > - set whitespaces in tap.h > - remove unnecessary goto >=20 > Pascal Mazon (4): > net/tap: move private elements to external header > net/tap: add preliminary support for rte_flow > net/tap: add netlink back-end for flow API > net/tap: add basic flow API patterns and actions >=20 > doc/guides/nics/features/tap.ini | 1 + > doc/guides/nics/tap.rst | 23 + > drivers/net/tap/Makefile | 44 ++ > drivers/net/tap/rte_eth_tap.c | 101 ++-- > drivers/net/tap/rte_eth_tap.h | 80 +++ > drivers/net/tap/tap_flow.c | 1070 +++++++++++++++++++++++++++++++++= +++++ > drivers/net/tap/tap_flow.h | 58 +++ > drivers/net/tap/tap_netlink.c | 367 +++++++++++++ > drivers/net/tap/tap_netlink.h | 69 +++ > drivers/net/tap/tap_tcmsgs.c | 378 ++++++++++++++ > drivers/net/tap/tap_tcmsgs.h | 63 +++ > 11 files changed, 2219 insertions(+), 35 deletions(-) > create mode 100644 drivers/net/tap/rte_eth_tap.h > create mode 100644 drivers/net/tap/tap_flow.c > create mode 100644 drivers/net/tap/tap_flow.h > create mode 100644 drivers/net/tap/tap_netlink.c > create mode 100644 drivers/net/tap/tap_netlink.h > create mode 100644 drivers/net/tap/tap_tcmsgs.c > create mode 100644 drivers/net/tap/tap_tcmsgs.h >=20 > --=20 > 2.12.0.306.g4a9b9b3 >=20 Acked-by: Keith Wiles Did not add my ack to the list, but that is OK I guess. I still think all headers in DPDK should have the C++ ifdefs as it does not= hurt in anyway and just make sure someone does not include it directly. Regards, Keith