From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by dpdk.org (Postfix) with ESMTP id E10DAA48D for ; Wed, 17 Jan 2018 09:53:10 +0100 (CET) Received: from WTL-EXCHSV2-1.sandvine.com (192.168.194.58) by WTL-EXCHSV2-2.sandvine.com (192.168.194.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.1034.26; Wed, 17 Jan 2018 03:53:08 -0500 Received: from WTL-EXCHP-1.sandvine.com (192.168.194.176) by WTL-EXCHSV2-1.sandvine.com (192.168.194.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.1034.26 via Frontend Transport; Wed, 17 Jan 2018 03:53:07 -0500 Received: from BLR-EXCHP-2.sandvine.com ([fe80::c8c4:1c2a:2ea3:e874]) by wtl-exchp-1.sandvine.com ([::1]) with mapi id 14.03.0319.002; Wed, 17 Jan 2018 03:53:08 -0500 From: Tushar Mulkar To: "dev@dpdk.org" CC: "beilei.xing@intel.com" , "qi.z.zhang@intel.com" , Tushar Mulkar Thread-Topic: [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv Thread-Index: AQHTjhEz+ekru50vuESX9YaZIPA1CqN3xOEg Date: Wed, 17 Jan 2018 08:53:07 +0000 Message-ID: References: <20180115145739.122013-1-tmulkar@sandvine.com> In-Reply-To: <20180115145739.122013-1-tmulkar@sandvine.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.30.10.127] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-C2ProcessedOrg: b2f06e69-072f-40ee-90c5-80a34e700794 Subject: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 08:53:11 -0000 The check for bool was accounting unwanted bits in the calulation of truth = value Signed-off-by: Tushar Mulkar --- drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethd= ev_vf.c index b96d77a0c..9c14ea278 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2095,7 +2095,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, } /* full duplex only */ new_link.link_duplex =3D ETH_LINK_FULL_DUPLEX; - new_link.link_status =3D vf->link_up ? ETH_LINK_UP : + new_link.link_status =3D (vf->link_up & true) ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg =3D dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED; --=20 2.11.0