From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by dpdk.org (Postfix) with ESMTP id 07AD81C01; Wed, 25 Jul 2018 19:04:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PjAEjCMKTH7WMD9B58aqskwr0uLoNZACeu+f+k5X9GU=; b=CUjW87eR+pSEx91PcRygec7+g67Y1z9FB7bY1gD3GRVLPczioTwrJ13+MbOS2cj4ksiV2jI18/5hkUOUJVNDG3OEKgbQcK733FlrJslAG9y5NNCcunGabRGbKlrUzyj7i6LaertsctpOuWjwHwp1x5kvIs7AYlyGOYMWeW48d94= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2176.eurprd05.prod.outlook.com (10.169.134.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Wed, 25 Jul 2018 17:04:32 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175%2]) with mapi id 15.20.0973.022; Wed, 25 Jul 2018 17:04:32 +0000 From: Yongseok Koh To: Adrien Mazarguil CC: Shahaf Shuler , "dev@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value Thread-Index: AQHUJAogS/1VYgUn5kuNUqBO6KyXXqSgKweA Date: Wed, 25 Jul 2018 17:04:32 +0000 Message-ID: References: <20180725112249.11148-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180725112249.11148-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2176; 6:DeVqd/d7PPTvDRZ6TOyGP3UfKX88lz1xa0815CIBrevp50jWimVG5jSOCcTyJsqKbXFIeJJNECxuyK3170ELyjMm2x240wRZXBMTsCoD2mxtq5RoKOP3u1uHsbu797312qSYRj/REVjoXL6fYKxVKeWfqoLlKjehL/FvyQPo99nLFp6WteH8h1On0mX0OkCiSu4h0yioPF8mnGE1fW6Zv9M5Nt8Zgj0bSkGHo3Q5DARKlx5yS5n7r+VwKw47mCOjs6jKl4U4RLxPIP3nZ9BZrVJajsyevg2cLOSSo/zeqXbkI2iWS0FeVV55JeJQbqSVivLrRIZOzoN91b+0oik+g9WTCSMdjqtJtCcPeu52fq77gA80SJo0Pm2xwZcPc4sHF5UcFqQafEc9Aq+DbE10YCnN8nYROONDepGqX0hT9aNfBvihpQgC57MaZkXFOh5teIjszfQi0kgI2erVLf9yJg==; 5:z0r776GNhvV3FiCdn7oE+WDJZ0J4vsNAQv6kTcGZEj+LV/nKwzkmG0t437+G8EcUgblouToTyEfxKO8xz/Rp3o6bLg6T3p1e4YXzYoeMlQKgLv0bW+Ht3o2QGVWr2L97gAraSuLsIMERkkXR1vY4FXdw/XNMbAU8DkG0mcUxMVY=; 7:cvlRBIAAtKwSrTqr/xmME2LFQqcUaBjGMAZ4xrXFEQMSSDnQvNdWp/WjMkBi7WoYiojXeJ1xZNL9SArwIOxQ3Aq6T2STZkKX6Gmkx0Jikr/8ri7sGzdmarU4//7h5UHh1sYZHkmJin9+hZMYjynT/aSAhsBnsDtsxD2AsX4UFBJ9DTDQVY18BuZ5PyZ1Mlb85mfqpgtNOjBMchnpsPb8TH2v1m4/i1gGadKXZhysZoQnZPg/OmaP8p0tnNVC0nD0 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 3e343964-1305-47a0-0668-08d5f250b14c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2176; x-ms-traffictypediagnostic: VI1PR0501MB2176: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2176; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2176; x-forefront-prvs: 0744CFB5E8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(396003)(366004)(39860400002)(199004)(189003)(25786009)(2616005)(6246003)(478600001)(186003)(105586002)(486006)(2906002)(86362001)(4326008)(11346002)(53936002)(54906003)(476003)(102836004)(316002)(26005)(99286004)(81156014)(6916009)(83716003)(6506007)(53546011)(14454004)(106356001)(446003)(33656002)(229853002)(36756003)(6486002)(6436002)(6512007)(68736007)(3846002)(82746002)(66066001)(5250100002)(6116002)(7736002)(97736004)(76176011)(81166006)(8936002)(256004)(305945005)(2900100001)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2176; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8100uvMHqshVADhHX7zMejch7LVGjiA0xcrBw9uGsow3KHJ4OKeCFHSdXAawqrYwL4zmlrx73vCxxUXQRv4Clxf1pNmgKrTfUJ667XlurWaUeJcRL9RF39j4SoI364aW5BO1RfFviWVDwZ/C+m7WVwdvNwH0jY+y8g9WARZZ+A6PRlkyTVexTFqzKF865Hb1CvZkTHdWQ46xbETJ+Gw8W/J+z8Hm8jo+PMFSB/6F9IJhmCQgY1b3Tsks/FzVCTvNO1O5uDkDJ5ohp4xixQm9S216gozVIlAMkqfjzRsleWbOypMcG2OzGznJBe2icb8B/GPL6LxDnH6axh4llqQMUtZLIb8bWgjZRWD3k/e77zw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <789E1AAF596777409D2E3A395CA63B7B@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e343964-1305-47a0-0668-08d5f250b14c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2018 17:04:32.5966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2176 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 17:04:35 -0000 > On Jul 25, 2018, at 4:24 AM, Adrien Mazarguil wrote: >=20 > Network interface indices being unsigned, an invalid index or error is > normally expressed through a zero value (see if_nametoindex()). >=20 > mlx5_ifindex() has a signed return type for negative values in case of > error. Since mlx5_nl.c does not check for errors, these may be fed back a= s > invalid interfaces indices to subsequent system calls. This usage would > have been correct if mlx5_ifindex() returned a zero value instead. >=20 > This patch makes mlx5_ifindex() unsigned for convenience. >=20 > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Cc: Nelio Laranjeiro > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil > Acked-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh =20 Thanks=