From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 66CA3C51C for ; Thu, 30 Jul 2015 11:59:14 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 30 Jul 2015 02:58:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,576,1432623600"; d="scan'208";a="738697115" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 30 Jul 2015 02:58:54 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.149]) by irsmsx105.ger.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0224.002; Thu, 30 Jul 2015 10:58:53 +0100 From: "Mcnamara, John" To: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue Thread-Index: AQHQyqKaAoKPaskL7UKEXvmulww7xp3zxhMw Date: Thu, 30 Jul 2015 09:58:52 +0000 Message-ID: References: <1438245257-7328-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1438245257-7328-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 09:59:14 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, July 30, 2015 9:34 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue >=20 > Ieee1588 reads system time to set its timestamp. On 1G NICs, for example, > i350, system time is disabled by default. It means the ieee1588 timestamp > will always be 0. > This patch enables system time when ieee1588 is enabled. Looks good. > +#define E1000_TSAUXC_DISABLE_SYSTIME 0x80000000 Probably best to move this to the top of the file with the other timesync d= efines. I wonder if this would also fix the following known issue with i210 timesyn= cing from the release notes: http://dpdk.org/doc/guides/rel_notes/known_issues.html#ieee1588-support-pos= sibly-not-working-with-an-intel-ethernet-controller-i210-nic I don't have an i210 NIC to test but perhaps someone could verify it. John