From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Alejandro.Lucero <alejandro.lucero@netronome.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] Support for Netronome´s NFP-6xxx card
Date: Mon, 5 Oct 2015 10:52:36 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202370D93@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1443785140-8706-1-git-send-email-alejandro.lucero@netronome.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alejandro.Lucero
> Sent: Friday, October 2, 2015 12:26 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/3] Support for Netronome´s NFP-6xxx card
>
> From: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
>
> Alejandro.Lucero (3):
> This patch adds a PMD driver for Netronome NFP PCI cards.
> This patch adds a new UIO driver for Netronome NFP PCI cards.
> Modifying configuration scripts for Netronome's nfp_uio driver.
Hi,
Thank you for submitting this. It is a good addition to DPDK.
Some minor comments to help the patchset get accepted.
It looks like the DPDK coding standard has been applied but check the guidelines for any differences:
http://dpdk.org/doc/guides/contributing/coding_style.html
It is also worth checking the patchset with the Linux kernel checkpatch utility. Not all kernel warnings are relevant to DPDK but most are. The following is an example check:
linux/scripts/checkpatch.pl --ignore PREFER_KERNEL_TYPES,SPLIT_STRING,VOLATILE -q patches*.patch
The first patch contains a doc patch. These are generally submitted in a separate patch as part of the patchset. Also it needs an addition to the index in doc/guides/nics/index.rst to actually include it in the documentation. Finally the RST has a few minor issues. See the doc guidelines for a how-to on installing and running the doc build system and the suggested formatting for the documentation.
http://dpdk.org/doc/guides/contributing/documentation.html
John.
--
prev parent reply other threads:[~2015-10-05 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 11:25 Alejandro.Lucero
2015-10-02 11:25 ` [dpdk-dev] [PATCH 1/3] This patch adds a PMD driver for Netronome NFP PCI cards Alejandro.Lucero
2015-10-02 11:25 ` [dpdk-dev] [PATCH 2/3] This patch adds a new UIO " Alejandro.Lucero
2015-10-02 11:25 ` [dpdk-dev] [PATCH 3/3] Modifying configuration scripts for Netronome's nfp_uio driver Alejandro.Lucero
2015-10-05 10:52 ` Mcnamara, John [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE202370D93@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).