From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Horton, Remy" <remy.horton@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example
Date: Mon, 5 Oct 2015 11:16:15 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202370E9C@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <4778653.jvL6ac5tEo@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, September 15, 2015 2:11 PM
> To: Horton, Remy
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example
>
> Hi,
>
> 2015-09-15 13:16, Remy Horton:
> > Provides a basic framework for detecting and reporting live-ness of
> > LCores, the primary requirement of which is minimal overheads for the
> > core(s) being checked. Core failures are notified via an application
> > defined callback. As an example l2fwd with random failures is used.
>
> ...
> Please try to use an existing example instead of creating a new one.
Hi,
I don't know if this is a good general rule.
If the feature is distinct then a new sample application is appropriate. Grouping too much functionality into a single sample app makes them less useful as reference implementations of different DPDK functionality. The l2fwd application, for example, has become cluttered with different functionality.
John.
--
next prev parent reply other threads:[~2015-10-05 11:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:16 Remy Horton
2015-09-15 13:10 ` Thomas Monjalon
2015-09-23 9:00 ` Remy Horton
2015-10-05 11:16 ` Mcnamara, John [this message]
2015-09-30 9:04 ` [dpdk-dev] [PATCH v2 0/3] Keepalive monitoring & reporting Remy Horton
2015-09-30 9:04 ` [dpdk-dev] [PATCH v2 1/3] rte: add keep alive functionality Remy Horton
2015-10-23 11:40 ` Tahhan, Maryam
2015-10-23 14:27 ` Wiles, Keith
2015-10-26 16:36 ` Remy Horton
2015-09-30 9:04 ` [dpdk-dev] [PATCH v2 2/3] l2fwd: keep alive sample application Remy Horton
2015-10-23 14:23 ` Tahhan, Maryam
2015-10-27 8:48 ` Remy Horton
2015-10-27 10:10 ` Bruce Richardson
2015-09-30 9:04 ` [dpdk-dev] [PATCH v2 3/3] docs: add keep alive sample app guide Remy Horton
2015-10-28 8:52 ` [dpdk-dev] [PATCH v3 0/3] Keepalive monitoring & reporting Remy Horton
2015-10-28 8:52 ` [dpdk-dev] [PATCH v3 1/3] rte: add keep alive functionality Remy Horton
2015-10-28 12:25 ` Tahhan, Maryam
2015-11-04 1:48 ` Thomas Monjalon
2015-11-04 1:54 ` Thomas Monjalon
2015-10-28 8:52 ` [dpdk-dev] [PATCH v3 2/3] docs: add keep alive sample app guide Remy Horton
2015-10-28 11:22 ` Van Haaren, Harry
2015-10-28 8:52 ` [dpdk-dev] [PATCH v3 3/3] example: add keep alive sample application Remy Horton
2015-10-28 12:28 ` Tahhan, Maryam
2015-11-05 11:32 ` [dpdk-dev] [PATCH v4 0/3] Keepalive monitoring & reporting Remy Horton
2015-11-05 11:32 ` [dpdk-dev] [PATCH v4 1/3] rte: add keep alive functionality Remy Horton
2015-11-05 16:43 ` Tahhan, Maryam
2015-11-10 14:02 ` Thomas Monjalon
2015-11-11 9:21 ` Remy Horton
2015-11-11 16:28 ` Stephen Hemminger
2015-11-18 10:21 ` Remy Horton
2015-11-13 16:09 ` Thomas Monjalon
2015-11-05 11:32 ` [dpdk-dev] [PATCH v4 2/3] docs: add keep alive sample app guide & release notes Remy Horton
2015-11-05 16:40 ` Van Haaren, Harry
2015-11-05 11:32 ` [dpdk-dev] [PATCH v4 3/3] example: add keep alive sample application Remy Horton
2015-11-05 16:44 ` Tahhan, Maryam
2015-11-11 6:52 ` [dpdk-dev] [PATCH v4 0/3] Keepalive monitoring & reporting Cao, Min
2015-11-18 14:05 ` [dpdk-dev] [PATCH v5 " Remy Horton
2015-11-18 14:05 ` [dpdk-dev] [PATCH v5 1/3] rte: add keep alive functionality Remy Horton
2015-11-18 14:05 ` [dpdk-dev] [PATCH v5 2/3] docs: add keep alive sample app guide & release notes Remy Horton
2015-11-19 11:32 ` Thomas Monjalon
2015-11-19 11:43 ` Remy Horton
2015-11-18 14:05 ` [dpdk-dev] [PATCH v5 3/3] example: add keep alive sample application Remy Horton
2015-11-19 11:31 ` Thomas Monjalon
2015-11-19 14:49 ` [dpdk-dev] [PATCH v5 0/3] Keepalive monitoring & reporting Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE202370E9C@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).