From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2053E8DA7 for ; Mon, 5 Oct 2015 13:16:18 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 05 Oct 2015 04:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,638,1437462000"; d="scan'208";a="819611597" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 05 Oct 2015 04:16:17 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.168]) by IRSMSX104.ger.corp.intel.com ([169.254.5.46]) with mapi id 14.03.0248.002; Mon, 5 Oct 2015 12:16:16 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "Horton, Remy" Thread-Topic: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example Thread-Index: AQHQ77B4L9gNDCd1Wk68/1AEZ3LKmp49f7YAgB9dROA= Date: Mon, 5 Oct 2015 11:16:15 +0000 Message-ID: References: <1442319413-3614-1-git-send-email-remy.horton@intel.com> <4778653.jvL6ac5tEo@xps13> In-Reply-To: <4778653.jvL6ac5tEo@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 11:16:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, September 15, 2015 2:11 PM > To: Horton, Remy > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example >=20 > Hi, >=20 > 2015-09-15 13:16, Remy Horton: > > Provides a basic framework for detecting and reporting live-ness of > > LCores, the primary requirement of which is minimal overheads for the > > core(s) being checked. Core failures are notified via an application > > defined callback. As an example l2fwd with random failures is used. >=20 > ... > Please try to use an existing example instead of creating a new one. Hi, I don't know if this is a good general rule. If the feature is distinct then a new sample application is appropriate. Gr= ouping too much functionality into a single sample app makes them less usef= ul as reference implementations of different DPDK functionality. The l2fwd = application, for example, has become cluttered with different functionality= . John. --=20