From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id BE42A8E85
 for <dev@dpdk.org>; Mon, 12 Oct 2015 12:46:51 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 12 Oct 2015 03:46:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,672,1437462000"; d="scan'208";a="824842618"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 12 Oct 2015 03:46:49 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.98]) with mapi id 14.03.0248.002;
 Mon, 12 Oct 2015 11:46:49 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 02/20] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
Thread-Index: AQHQ/1j7DM+6H2jQdEu3n4yA/0W0255ntdIA
Date: Mon, 12 Oct 2015 10:46:48 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20237EA12@IRSMSX103.ger.corp.intel.com>
References: <PATCH v2>
 <1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>
 <1444041035-4936-3-git-send-email-bernard.iremonger@intel.com>
In-Reply-To: <1444041035-4936-3-git-send-email-bernard.iremonger@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 02/20] librte_ether: add fields
	from	rte_pci_driver to rte_eth_dev_data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Oct 2015 10:46:52 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Monday, October 5, 2015 11:30 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 02/20] librte_ether: add fields from
> rte_pci_driver to rte_eth_dev_data
>=20
> add dev_flags to rte_eth_dev_data, add macros for dev_flags.
> add kdrv to rte_eth_dev_data.
> add numa_node to rte_eth_dev_data.
> add drv_name to rte_eth_dev_data.
> use dev_type to distinguish between vdev's and pdev's.
> remove pci_dev branches.


Hi Bernard,

Patch 02/20 doesn't compile without patch 03/20 also being applied:


    $ git log --pretty=3Doneline --abbrev-commit -2=20
    0958ce7 librte_ether: add fields from rte_pci_driver to rte_eth_dev_dat=
a
    30e65e6 librte_eal: add RTE_KDRV_NONE for vdevs

    $ make T=3Dx86_64-native-linuxapp-gcc -j install
    ...
    lib/librte_ether/rte_ethdev.c:3341:1: error: no previous prototype for
    'rte_eth_copy_dev_info' [-Werror=3Dmissing-prototypes]
    cc1: all warnings being treated as errors


John