DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Francesco Montorsi <francesco.montorsi@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Add build switches for all DPDK applications.	This makes it possible to skip building applications (and	build only libraries or kernel drivers).
Date: Fri, 30 Oct 2015 16:39:47 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202394DF6@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1446215253-3188-1-git-send-email-francesco.montorsi@gmail.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Francesco Montorsi
> Sent: Friday, October 30, 2015 2:28 PM
> To: dev@dpdk.org
> Cc: Francesco Montorsi
> Subject: [dpdk-dev] [PATCH] Add build switches for all DPDK applications.
> This makes it possible to skip building applications (and build only
> libraries or kernel drivers).

Hi,

Thanks for the patch.

The patch needs to signed and the title is too long (part of it should be in the body). See the following contributing guidelines:

    http://dpdk.org/dev/patchwork/patch/7935/

I don't know if people will want to add more compile time options. In general we are trying to remove them.

I do like the idea of being able to turn off building app/test which can a long time (even with -j).

Maybe it should only be built when you run "make test".

John.
-- 

      reply	other threads:[~2015-10-30 16:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 14:27 Francesco Montorsi
2015-10-30 16:39 ` Mcnamara, John [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE202394DF6@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=francesco.montorsi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).