DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: 'Thomas Monjalon' <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read the docs theme
Date: Sun, 1 Nov 2015 16:41:52 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20239597A@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <2449554.9X2Y58lndV@xps13>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 26, 2015 2:34 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: change sphinx theme to the read
> the docs theme
> 
> 2015-10-21 10:39, John McNamara:
> > Change the Sphinx default theme from "alabaster" to the ReadTheDocs
> > theme. See for example:
> >
> >     http://dpdk.readthedocs.org/en/latest/
> >
> > This looks better for technical documentation and in particular it has
> > a 80 char wide verbatim block rendering.
> 
> Yes it is a clean theme.
> It would be nice to add the DPDK logo somewhere.

Hi,

I'll submit a V3 with a logo for the html and pdf docs.

Note, the SVG logos are quite big (2 are required) and converting them to pdf for the Latex pdf docs requires another addition to the makefiles. This is a case where the patch would be smaller and simpler with PNG files and where the images are unlikely to require editing.


> > Also turn off option for distracting Html mouseover permalinks.
> [...]
> > +html_add_permalinks = ""
> 
> I think the permalinks are very useful to point a specific doc chapter to
> someone else.


It is just as easy to get a link to a subsection from the index. The permalinks are distracting because they blink on and off when scrolling through the docs. Also, I doubt more than a handful of people will know what the permalinks in the Html docs are.

Anyway, I'll remove this part from the patch and submit it separately. If there is any support for it the patch can be applied, if not then you can reject it.

John.
-- 

  reply	other threads:[~2015-11-01 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 11:31 [dpdk-dev] [PATCH] " John McNamara
2015-10-21  9:39 ` [dpdk-dev] [PATCH v2] " John McNamara
2015-10-23 17:35   ` Van Haaren, Harry
2015-10-26 14:33   ` Thomas Monjalon
2015-11-01 16:41     ` Mcnamara, John [this message]
2015-11-01 18:36       ` Thomas Monjalon
2015-11-01 19:39         ` Mcnamara, John
2015-11-01 23:29 ` [dpdk-dev] [PATCH v4] doc: change sphinx theme and add logos John McNamara
2015-12-13 21:34   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE20239597A@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).