From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3B801591E for ; Mon, 9 Nov 2015 12:45:30 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 09 Nov 2015 03:45:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,265,1444719600"; d="scan'208";a="846023188" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 09 Nov 2015 03:45:05 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX107.ger.corp.intel.com ([169.254.10.132]) with mapi id 14.03.0248.002; Mon, 9 Nov 2015 11:45:05 +0000 From: "Mcnamara, John" To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Olivier Matz" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size to 512 Thread-Index: AQHRF7CYvsh7YQVnRE65943sySgx956NpNgAgAXyAWA= Date: Mon, 9 Nov 2015 11:45:04 +0000 Message-ID: References: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com> <20151105165044.GA18667@autoinstall.dev.6wind.com> In-Reply-To: <20151105165044.GA18667@autoinstall.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size to 512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 11:45:30 -0000 > -----Original Message----- > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Thursday, November 5, 2015 4:51 PM > To: Mcnamara, John; Olivier Matz; Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size > to 512 >=20 > On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote: > > Increase commandline buffer size to 512 to allow for longer > > commandlines required by testpmd when dealing with flow director and > > IPv6 addresses. > > > > ... > > > > /* configuration */ > > -#define RDLINE_BUF_SIZE 256 > > +#define RDLINE_BUF_SIZE 512 > > >=20 > I have faced the same issue. For some commands this value is still too > low. For example, RETA update can not be used, the command line limits > he configuration to 34 entries. >=20 > See http://dpdk.org/ml/archives/dev/2015-October/024681.html > and particularly > http://dpdk.org/ml/archives/dev/2015-October/024682.html >=20 > It was too late to announce an ABI change so we left out the cmdline > size update. >=20 > Olivier, Thomas, what do you think about this? It seems this is really > blocking. Hi, Since the change breaks ABI I'll self nack. However, this is something that should be fixed since it will affect any DP= DK application with a long commandline. I can put a warning of future ABI breakage in the release notes but I see t= hat there are other #defines that you need to increase in your patchset so = do you want to submit the ABI deprecation notice? John. --=20