From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 19FBF58C3 for ; Wed, 18 Nov 2015 11:39:42 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 18 Nov 2015 02:39:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,312,1444719600"; d="scan'208";a="822993960" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga001.jf.intel.com with ESMTP; 18 Nov 2015 02:39:42 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 10:39:40 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by irsmsx155.ger.corp.intel.com ([169.254.14.150]) with mapi id 14.03.0248.002; Wed, 18 Nov 2015 10:39:40 +0000 From: "Mcnamara, John" To: "Wang, Zhihong" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Thread-Index: AQHRIewt0EBx9133vkOYaV0u+sl0sp6hlhLw Date: Wed, 18 Nov 2015 10:39:39 +0000 Message-ID: References: <1447817231-10510-1-git-send-email-zhihong.wang@intel.com> <1447817231-10510-3-git-send-email-zhihong.wang@intel.com> In-Reply-To: <1447817231-10510-3-git-send-email-zhihong.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2015 10:39:43 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang > Sent: Wednesday, November 18, 2015 3:27 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary > hugepage zero-filling >=20 > The kernel fills new allocated (huge) pages with zeros. > DPDK just has to touch the pages to trigger the allocation. >=20 > ... > if (orig) { > hugepg_tbl[i].orig_va =3D virtaddr; > - memset(virtaddr, 0, hugepage_sz); > + memset(virtaddr, 0, 8); > } Probably worth adding a one or two line comment here to avoid someone think= ing that it is a bug at some later stage. The text in the commit message ab= ove is suitable. John. --=20