From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 392EC8E7E
 for <dev@dpdk.org>; Tue, 24 Nov 2015 18:49:07 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 24 Nov 2015 09:49:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,339,1444719600"; d="scan'208";a="606443232"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by FMSMGA003.fm.intel.com with ESMTP; 24 Nov 2015 09:49:05 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.251]) with mapi id 14.03.0248.002;
 Tue, 24 Nov 2015 17:49:04 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 2/2] scripts: add build tests
Thread-Index: AQHRJZA57zLu/DvRVU+6ODdblZ03YZ6rciLw
Date: Tue, 24 Nov 2015 17:49:02 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2023C3516@IRSMSX103.ger.corp.intel.com>
References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com>
 <1448242808-16101-1-git-send-email-thomas.monjalon@6wind.com>
 <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/2] scripts: add build tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 17:49:07 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, November 23, 2015 1:40 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] scripts: add build tests
>=20
> ...
>
> +while getopts hj:q ARG ; do
> +	case $ARG in
> +		j ) J=3D$OPTARG ;;
> +		q ) quick=3Dtrue ;;
> +		h ) print_usage ; exit 0 ;;
> +		? ) print_usage ; exit 1 ;;

Hi John,

Very useful. We should add these scripts to the contributing guide at some =
point.

One minor nit. "q" is used for "quick" in this script and "quiet" in the ch=
eckpatch script. Maybe for consistency use "f" for fast or "n" for no-doc o=
r something else.

John.
--=20
=20