From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 1C89F568A
for <dev@dpdk.org>; Thu, 3 Dec 2015 13:14:27 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga101.fm.intel.com with ESMTP; 03 Dec 2015 04:14:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="699448489"
Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28])
by orsmga003.jf.intel.com with ESMTP; 03 Dec 2015 04:14:19 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by
irsmsx105.ger.corp.intel.com ([169.254.7.203]) with mapi id 14.03.0248.002;
Thu, 3 Dec 2015 12:14:18 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] scripts: support any legal git revisions as
abi validation range
Thread-Index: AQHRLSGuRmWWDWSgGU6ItmN2p7J++Z65KtAQ
Date: Thu, 3 Dec 2015 12:14:17 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2023CC9B0@IRSMSX103.ger.corp.intel.com>
References: <aa1719d759d44dd62166432ed2179ac2c66e79b5.1449075047.git.pmatilai@redhat.com>
In-Reply-To: <aa1719d759d44dd62166432ed2179ac2c66e79b5.1449075047.git.pmatilai@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] scripts: support any legal git revisions as
abi validation range
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 12:14:28 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, December 2, 2015 4:51 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as
> abi validation range
>=20
> In addition to git tags, support validating abi between any legal
> gitrevisions(7) syntaxes, such as "validate-abi.sh . -1 <target>"
> "validate-abi.sh master mybrach <target>" etc in addition to validating
> between tags. Makes it easier to run the validator for in-development
> work.
Hi Panu,
+1 for this.
You might also change the ABI validation section of the docs to go along
with this. Something like the patch below. If not I'll submit it
afterwards.=20
Also, if someone has some bandwidth it would be good to add an option
to pass -j with an optional number to "make" in the script.
John
$ git diff =20
diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributi=
ng/versioning.rst
index 653c7d0..5ce5f9d 100644
--- a/doc/guides/contributing/versioning.rst
+++ b/doc/guides/contributing/versioning.rst
@@ -465,19 +465,23 @@ utilities which can be installed via a package manage=
r. For example::
=20
sudo yum install abi-compliance-checker
sudo yum install abi-dumper
+ sudo yum install greadelf
=20
The syntax of the ``validate-abi.sh`` utility is::
=20
- ./scripts/validate-abi.sh <TAG1> <TAG2> <TARGET>
+ ./scripts/validate-abi.sh <REV1> <REV2> <TARGET>
=20
-Where ``TAG1`` and ``TAG2`` are valid git tags on the local repo and targe=
t is
-the usual DPDK compilation target.
+Where ``REV1`` and ``REV2`` are valid `gitrevisions(7)
+<https://www.kernel.org/pub/software/scm/git/docs/gitrevisions.html>`_ on =
the
+local repo and ``TARGET`` is the usual DPDK compilation target.
=20
-For example to test the current committed HEAD against a previous release =
tag
-we could add a temporary tag and run the utility as follows::
+For example::
=20
- git tag MY_TEMP_TAG
- ./scripts/validate-abi.sh v2.0.0 MY_TEMP_TAG x86_64-native-linuxapp-gcc
+ # Check between the previous and latest commits:
+ ./scripts/validate-abi.sh HEAD~1 HEAD x86_64-native-linuxapp-gcc
+
+ # Check between two tags:
+ ./scripts/validate-abi.sh v2.1.0 v2.2.0 x86_64-native-linuxapp-gcc
=20
After the validation script completes (it can take a while since it need t=
o
compile both tags) it will create compatibility reports in the