From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 00269567E for ; Tue, 8 Dec 2015 17:59:35 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 08 Dec 2015 08:59:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,400,1444719600"; d="scan'208";a="9669789" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga004.fm.intel.com with ESMTP; 08 Dec 2015 08:59:33 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 8 Dec 2015 16:59:33 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by irsmsx112.ger.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002; Tue, 8 Dec 2015 16:59:33 +0000 From: "Mcnamara, John" To: "Mcnamara, John" , "Azarewicz, PiotrX T" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue Thread-Index: AQHRMcL26I6WQb2b4EyFt5Ys0IsTJ57BKxSAgAAklvA= Date: Tue, 8 Dec 2015 16:59:31 +0000 Message-ID: References: <1449584208-24987-1-git-send-email-piotrx.t.azarewicz@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 16:59:36 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > Sent: Tuesday, December 8, 2015 2:47 PM > To: Azarewicz, PiotrX T; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > issue >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz > > Sent: Tuesday, December 8, 2015 2:17 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > > issue > > > > The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t. > > So the goal is to copy elements size of cmdline_parse_ctx_t not > > cmdline_parse_ctx_t*. > > > > Coverity issue: 120412 > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding > > dynamically") > > > > Signed-off-by: Piotr Azarewicz >=20 > Acked-by: John McNamara Hi Piotr, This issue occurs copy and pasted in two other locations as well: examples/ip_pipeline/pipeline/pipeline_common_fe.c 1295: n_cmds * sizeof(cmdline_parse_ctx_t *)); examples/ip_pipeline/thread_fe.c 340: n_cmds * sizeof(cmdline_parse_ctx_t *)); examples/ip_pipeline/init.c 1475: n_cmds * sizeof(cmdline_parse_ctx_t *)); Perhaps you could fix those in the same patch. Thanks, John