DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] New Coverity warnings
@ 2015-12-08 16:50 Stephen Hemminger
  2015-12-08 17:19 ` Mcnamara, John
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2015-12-08 16:50 UTC (permalink / raw)
  To: dev

*** CID 120410:  Error handling issues  (CHECKED_RETURN)
/examples/l2fwd-keepalive/main.c: 571 in dead_core()
565     
566     static void
567     dead_core(__attribute__((unused)) void *ptr_data, const int id_core)
568     {
569     	printf("Dead core %i - restarting..\n", id_core);
570     	if (rte_eal_get_lcore_state(id_core) == FINISHED) {
>>>     CID 120410:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
571     		rte_eal_wait_lcore(id_core);
572     		rte_eal_remote_launch(l2fwd_launch_one_lcore, NULL, id_core);
573     	} else {
574     		printf("..false positive!\n");
575     	}
576     }

** CID 37790:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()


________________________________________________________________________________________________________
*** CID 37790:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()
587     					"lcore_main not running on core:%d\n",
588     					global_flag_stru_p->LcoreMainCore);
589     		rte_spinlock_unlock(&global_flag_stru_p->lock);
590     		return;
591     	}
592     	global_flag_stru_p->LcoreMainIsRunning = 0;
>>>     CID 37790:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
593     	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
594     	cmdline_printf(cl,
595     			"lcore_main stopped on core:%d\n",
596     			global_flag_stru_p->LcoreMainCore);
597     	rte_spinlock_unlock(&global_flag_stru_p->lock);
598     }

** CID 37789:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()


________________________________________________________________________________________________________
*** CID 37789:  Error handling issues  (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()
625     					global_flag_stru_p->LcoreMainCore);
626     		rte_spinlock_unlock(&global_flag_stru_p->lock);
627     		cmdline_quit(cl);
628     		return;
629     	}
630     	global_flag_stru_p->LcoreMainIsRunning = 0;
>>>     CID 37789:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).  
631     	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
632     	cmdline_printf(cl,
633     			"lcore_main stopped on core:%d\n",
634     			global_flag_stru_p->LcoreMainCore);
635     	rte_spinlock_unlock(&global_flag_stru_p->lock);
636     	cmdline_quit(cl);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-08 17:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-08 16:50 [dpdk-dev] New Coverity warnings Stephen Hemminger
2015-12-08 17:19 ` Mcnamara, John

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).