From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 024E1568B for ; Wed, 9 Dec 2015 15:20:47 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 06:20:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,403,1444719600"; d="scan'208";a="837642881" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 09 Dec 2015 06:20:45 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Dec 2015 14:20:42 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX156.ger.corp.intel.com ([169.254.3.110]) with mapi id 14.03.0248.002; Wed, 9 Dec 2015 14:20:42 +0000 From: "Mcnamara, John" To: "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH] doc: add fm10k driver Thread-Index: AQHRMlsn7A66UzNQR0eHTymBZKvFBZ7CrRNg Date: Wed, 9 Dec 2015 14:20:42 +0000 Message-ID: References: <1449649486-22505-1-git-send-email-jing.d.chen@intel.com> In-Reply-To: <1449649486-22505-1-git-send-email-jing.d.chen@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add fm10k driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 14:20:48 -0000 > -----Original Message----- > From: Chen, Jing D > Sent: Wednesday, December 9, 2015 8:25 AM > To: dev@dpdk.org > Cc: Mcnamara, John; Chen, Jing D > Subject: [PATCH] doc: add fm10k driver >=20 > From: "Chen Jing D(Mark)" >=20 > This documentation covers introdutions and limitations on Intel > FM10000 series products. Hi Mark, Thanks for that.=20 The docs build cleanly but there is one whitespace warning on merge. Minor comments below. > @@ -0,0 +1,54 @@ > +.. BSD LICENSE > + Copyright(c) 2010-2015 Intel Corporation. All rights reserved. The year should be 2015 only and this line shouldn't be indented in relatio= n to the next lines. > +FM10K Poll Mode Driver > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +The FM10K poll mode driver library provides support for Intel FM10000 > +family of 40GbE/100GbE adapters. The DPDK Documentation Guidelines say to leave a blank line after section headers (here and with the other sections):=20 > +FM10K Poll Mode Driver > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > +The FM10K poll mode driver library provides support for Intel FM10000 > +family of 40GbE/100GbE adapters. See: http://dpdk.org/doc/guides/contributing/documentation.html#rst-guide= lines > +The FM10K poll mode driver library provides support for Intel FM10000 > +family of 40GbE/100GbE adapters. Might be worth introducing the common FM10K name here as well: The FM10K poll mode driver library provides support for the Intel FM10000 (FM10K) family of 40GbE/100GbE adapters. > +Intel FM10000 family of NICs integrate an hardware switch and multiple > +host interfaces. FM10K PMD driver only manages host interfaces. For the The doc uses FM10000 in some places and FM10K in others. It should use one or the other consistently. > +switch component, another switch driver has to be loaded prior to FM10K > PMD driver. > +The switch driver either can be acquired by Intel support or from below > link: > +https://github.com/match-interface Better to add an actual link like: The switch driver can be acquired for Intel support or from the `Match Interface `_ project. Also should that be to: https://github.com/match-interface/match > + > +CRC strip > +FM10000 family always strip CRC for every packets coming into host > interface. Limitations ----------- Switch manager ~~~~~~~~~~~~~~ The Intel FM10000 family of NICs integrate a hardware switch and multiple h= ost Etc. > +Max packet length > +FM10000 family support maximum of 15K jumbo frame. The value is fixed > +and can't be changed. So, even (struct > +rte_eth_conf).rxmode.max_rx_pkt_len is set to a value other than 15364, > the frames with 15364 byte still can reach to host interface. This isn't clear (to me). Maybe something like: The FM10000 family of NICS support a maximum of a 15K jumbo frame. The valu= e is fixed and cannot be changed. So, even when the ``rxmode.max_rx_pkt_len`` member of ``struct rte_eth_conf`` is set to a value lower than 15364, frame= s up to 15364 bytes can still reach the host interface. Regards, John. --=20