From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 59CC59254 for ; Tue, 5 Jan 2016 11:22:08 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 05 Jan 2016 02:22:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,524,1444719600"; d="scan'208";a="720479127" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 05 Jan 2016 02:22:06 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 5 Jan 2016 10:21:59 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.143]) by irsmsx111.ger.corp.intel.com ([169.254.2.110]) with mapi id 14.03.0248.002; Tue, 5 Jan 2016 10:21:59 +0000 From: "Mcnamara, John" To: "Tan, Jianfeng" , "Xie, Huawei" , "dev@dpdk.org" Thread-Topic: [PATCH] fix checkpatch errors Thread-Index: AQHRRxf/cqDatPfefUO4rA/wdGQTDJ7sMU0AgACCiaA= Date: Tue, 5 Jan 2016 10:21:58 +0000 Message-ID: References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 10:22:08 -0000 > -----Original Message----- > From: Tan, Jianfeng > Sent: Tuesday, January 5, 2016 2:21 AM > To: Xie, Huawei; dev@dpdk.org > Cc: Mcnamara, John; Stephen Hemminger; Yuanhan Liu > Subject: RE: [PATCH] fix checkpatch errors >=20 >=20 >=20 > > -----Original Message----- > > From: Xie, Huawei > > Sent: Monday, January 4, 2016 9:52 AM > > To: dev@dpdk.org > > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei > > Subject: [PATCH] fix checkpatch errors > > > > Signed-off-by: Huawei Xie > ... > > mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name)); > > - return (rte_mempool_lookup((const char *)pool_name)); > > + return rte_mempool_lookup((const char *)pool_name); >=20 > Hi Huawei, >=20 > Assume this patch is to solve below error (reported by checkpatch): > ERROR: return is not a function, parentheses are not required >=20 > So maybe above fix is not necessary? Involve more people to discuss. >=20 > And please include the error message in the commit message. Hi Huawei, The fix looks good and there was a similar patch applied previously for lib= (from Ferruh): 6307b909b8e0 ("lib: remove extra parenthesis after return") However, the commit message could be better. Maybe something like the above= : "remove extra parentheses". John --=20