From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 58AF968F5 for ; Wed, 10 Feb 2016 18:12:00 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 10 Feb 2016 09:11:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,426,1449561600"; d="scan'208";a="650177805" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2016 09:11:58 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Feb 2016 17:11:57 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by irsmsx111.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002; Wed, 10 Feb 2016 17:11:57 +0000 From: "Mcnamara, John" To: Alejandro Lucero Thread-Topic: [PATCH v3 1/2] version: switch to year/month version numbers Thread-Index: AQHRZCTax+rwZ4WbY0SkF5/CYN6MGZ8lgnyg Date: Wed, 10 Feb 2016 17:11:57 +0000 Message-ID: References: <1450704384-9986-1-git-send-email-bruce.richardson@intel.com> <1455123732-1705-1-git-send-email-john.mcnamara@intel.com> In-Reply-To: <1455123732-1705-1-git-send-email-john.mcnamara@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ2ZGIzZGItMzNkYS00MmMzLWE2NGItNzc3Yzk5YmMyN2U0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijh1XC9SMkNrMjJibTlFRGJSSm15dGFQRjRvd0I0UWtDTlFEMDI3VnAyUzdzPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 17:12:00 -0000 > -----Original Message----- > From: Mcnamara, John > Sent: Wednesday, February 10, 2016 5:02 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Richardson, Bruce > ; Mcnamara, John > Subject: [PATCH v3 1/2] version: switch to year/month version numbers > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index > ffa5730..fd4dd39 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1070,9 +1070,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > }; >=20 > dev_info->reta_size =3D NFP_NET_CFG_RSS_ITBL_SZ;=20 >-#if RTE_VER_MAJOR =3D=3D 2 && RTE_VER_MINOR >=3D 1 > dev_info->hash_key_size =3D NFP_NET_CFG_RSS_KEY_SZ; >-#endif } >=20 Hi Alejandro, Please note the above change to the nfp_net.c code due to the name change in the version macro names. I was originally going to change it to this: #if RTE_VER_YEAR =3D=3D 2 && RTE_VER_MONTH >=3D 1 dev_info->hash_key_size =3D NFP_NET_CFG_RSS_KEY_SZ; #endif Or better: #if RTE_VERSION >=3D 0x02010000 dev_info->hash_key_size =3D NFP_NET_CFG_RSS_KEY_SZ; #endif However, since the code was added in DPDK 2.2 the version check doesn't see= m necessary, so I removed it. If you need it back in for some reason let me k= now. John