Re: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> Sent: Thursday, February 18, 2016 10:33 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
> 
> flake8 checks were run for both python 2.7 and 3.4
> 
> There were some style issues as:
> - Line width > 79
> - No double blank line before function definition
> - No double blank space before inline comment
> - Some other minor issues
> 
> Signed-off-by: Mauricio Vasquez B
> <mauricio.vasquezbernal@studenti.polito.it>

Hi,

Thanks for that. A lot of these issues were introduced with patch:

    16c1814c802c ("tools: support Python 3 in bind script")

I meant to comment on the previous patch but it was merged before I
got a chance.

>      dev_lines = check_output(["lspci", "-Dvmmn"]).splitlines()
>      for dev_line in dev_lines:
>          if (len(dev_line) == 0):
>              if dev["Class"] == ETHERNET_CLASS:
>                  #convert device and vendor ids to numbers, then add to

There is still one pep8 issue reported here:

   $ pep8 tools/dpdk_nic_bind.py 
   tools/dpdk_nic_bind.py:252:17: E265 block comment should start with '# '

Perhaps you can submit a v2 with that minor change. Otherwise:

Acked-by: John McNamara <john.mcnamara@intel.com>