From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A6A09C48C
 for <dev@dpdk.org>; Fri, 19 Feb 2016 15:02:40 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 19 Feb 2016 06:02:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,470,1449561600"; d="scan'208";a="919340709"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2016 06:02:39 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by
 IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002;
 Fri, 19 Feb 2016 14:02:32 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
Thread-Index: AQHRapxig96LHi3QDESd7cauQntO2p8zZKxg
Date: Fri, 19 Feb 2016 14:02:32 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20245C20B@IRSMSX103.ger.corp.intel.com>
References: <1455834773-5584-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>
In-Reply-To: <1455834773-5584-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQ5YTQ3YTItMGVmOC00MGIyLWE3MTAtYTdiNGYwN2M3NWJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJpSEh1RXdBZFZCOFBzU2Y5XC9za0tjTE1FNUJ6eUNUcHAyaTBkdHpqelwvZz0ifQ==
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Feb 2016 14:02:41 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> Sent: Thursday, February 18, 2016 10:33 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
>=20
> flake8 checks were run for both python 2.7 and 3.4
>=20
> There were some style issues as:
> - Line width > 79
> - No double blank line before function definition
> - No double blank space before inline comment
> - Some other minor issues
>=20
> Signed-off-by: Mauricio Vasquez B
> <mauricio.vasquezbernal@studenti.polito.it>

Hi,

Thanks for that. A lot of these issues were introduced with patch:

    16c1814c802c ("tools: support Python 3 in bind script")

I meant to comment on the previous patch but it was merged before I
got a chance.

>      dev_lines =3D check_output(["lspci", "-Dvmmn"]).splitlines()
>      for dev_line in dev_lines:
>          if (len(dev_line) =3D=3D 0):
>              if dev["Class"] =3D=3D ETHERNET_CLASS:
>                  #convert device and vendor ids to numbers, then add to

There is still one pep8 issue reported here:

   $ pep8 tools/dpdk_nic_bind.py=20
   tools/dpdk_nic_bind.py:252:17: E265 block comment should start with '# '

Perhaps you can submit a v2 with that minor change. Otherwise:

Acked-by: John McNamara <john.mcnamara@intel.com>