From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2E8776CA0 for ; Mon, 16 May 2016 14:58:47 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 16 May 2016 05:58:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,627,1455004800"; d="scan'208";a="703786500" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by FMSMGA003.fm.intel.com with ESMTP; 16 May 2016 05:58:45 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.54]) by IRSMSX151.ger.corp.intel.com ([169.254.4.7]) with mapi id 14.03.0248.002; Mon, 16 May 2016 13:58:45 +0100 From: "Mcnamara, John" To: "Kobylinski, MichalX" , Thomas Monjalon CC: "dev@dpdk.org" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] cfgfile: fix integer overflow Thread-Index: AQHRoT6THEyNyr1YtEajo+FIHN8vcJ+7YcWAgAAuF4CAABItsA== Date: Mon, 16 May 2016 12:58:44 +0000 Message-ID: References: <1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479A6F0C@IRSMSX108.ger.corp.intel.com> <1677876.8C2acBUBqJ@xps13> <987EE72691933347B9F0B5C19E71B5BB1F08244D@IRSMSX101.ger.corp.intel.com> In-Reply-To: <987EE72691933347B9F0B5C19E71B5BB1F08244D@IRSMSX101.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWY4NzM5YWEtMmFhMy00NWY0LTliNGYtMGFhM2EyNWM4MmQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJKdlpIMTVwQVMzMHNsVEgzTkRCbEZSRDNQcm4zT09UWlEzeFd4QjNxTHM9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix integer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 12:58:47 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kobylinski, MichalX > Sent: Monday, May 16, 2016 1:51 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix integer overflow > ... > Coverity show that there is overflowed value. > But the second parameter will never be greater than 254 (its range is 0 - > 254). > I used cast this parameter to unsigned in order that resolved bug reporte= d > by static analysis. Hi, If the error cannot happen in a real application then you can mark the defe= ct as a false positive in Coverity. Add some of the information provided above= as to why it is a false positive to the comments section of the defect or add = a=20 link to the patchwork discussion. John