From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B95933B5 for ; Thu, 9 Jun 2016 14:35:35 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 09 Jun 2016 05:35:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,444,1459839600"; d="scan'208";a="118915742" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 09 Jun 2016 05:35:33 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by IRSMSX109.ger.corp.intel.com ([169.254.13.193]) with mapi id 14.03.0248.002; Thu, 9 Jun 2016 13:35:32 +0100 From: "Mcnamara, John" To: "Wang, Zhihong" , "dev@dpdk.org" CC: "Wang, Zhihong" Thread-Topic: [dpdk-dev] [PATCH] doc: virtio pmd versions Thread-Index: AQHRm70tRbPMSB/E50e0MjINYMJ925/hXDCw Date: Thu, 9 Jun 2016 12:35:32 +0000 Message-ID: References: <1461210924-104947-1-git-send-email-zhihong.wang@intel.com> In-Reply-To: <1461210924-104947-1-git-send-email-zhihong.wang@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIxMGFmOTYtYjI5Ny00ZTVmLTg0YTctMWUwNDBlMmU2Mjk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhxQVY2dTNVNVZsd3U4c0d5aVwvQ0lEN2RiUzdwcVBHWUpyS1Vhck94b3dzPSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: virtio pmd versions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 12:35:36 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang > Sent: Thursday, April 21, 2016 4:55 AM > To: dev@dpdk.org > Cc: Wang, Zhihong > Subject: [dpdk-dev] [PATCH] doc: virtio pmd versions >=20 > This patch explains all the versions of current virtio pmd implementation= , > what's the difference, and how to choose the right version. Hi, Thanks for the clarification docs. That should hopefully answer a frequentl= y asked question. Some minor comments below. > + > +Virtio PMD Versions > +------------------- > + > +Virtio driver has 3 versions of rx functions and 2 versions of tx > functions. In some places RX/TX is used and in some rx/tx. I would suggest the uppercase versions throughout. > + > +RX functions: > + > +* ``virtio_recv_pkts``: > + > + Regular version without mergeable rx buffers support Since these could be a numbered list I would suggest using "#." (numbered list) instead of "*" (bullet list). Also it would be better without a blank line between the name and the definition so that they appear on the same line in the generated docs. > + > + Simple version without mergeable rx buffers support, also fixes the > + avail ring and uses vector instructions to optimize performance s/avail/available in 2 places. Also should that be "available ring size" or "number of available rings" or something else? > +Example to use the simple version of virtio poll mode driver in testpmd: > + > +.. code-block:: console > + > +./x86_64-native-linuxapp-gcc/app/testpmd -c 0x7 -n 4 > + -- -i --txqflags=3D0xf01 --rxq=3D1 --txq=3D1 --nb-cores=3D1 The code/commandline needs to be indented 3-4 spaces to be rendered correctly. I'd also suggest omitting "./x86_64-native-linuxapp-gcc/app/" an= d just using "testpmd" since that commandline is target dependent. The comman= d would also fit on one line like that. Thanks, John. --=20