From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1CB331BBE
 for <dev@dpdk.org>; Thu,  9 Jun 2016 14:56:23 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 09 Jun 2016 05:56:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,444,1459839600"; d="scan'208";a="998539385"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 09 Jun 2016 05:56:22 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.10]) with mapi id 14.03.0248.002;
 Thu, 9 Jun 2016 13:56:21 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>, "Wang, Zhihong"
 <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Wang, Zhihong" <zhihong.wang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] doc: virtio pmd versions
Thread-Index: AQHRm70tRbPMSB/E50e0MjINYMJ925/hXDCw///3QICAABEwsA==
Date: Thu, 9 Jun 2016 12:56:20 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20257E5F9@IRSMSX103.ger.corp.intel.com>
References: <1461210924-104947-1-git-send-email-zhihong.wang@intel.com>
 <B27915DBBA3421428155699D51E4CFE20257E55D@IRSMSX103.ger.corp.intel.com>
 <59AF69C657FD0841A61C55336867B5B035A82F93@IRSMSX103.ger.corp.intel.com>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B035A82F93@IRSMSX103.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIxMGFmOTYtYjI5Ny00ZTVmLTg0YTctMWUwNDBlMmU2Mjk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhxQVY2dTNVNVZsd3U4c0d5aVwvQ0lEN2RiUzdwcVBHWUpyS1Vhck94b3dzPSJ9
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] doc: virtio pmd versions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2016 12:56:24 -0000

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Thursday, June 9, 2016 1:53 PM
> To: Mcnamara, John <john.mcnamara@intel.com>; Wang, Zhihong
> <zhihong.wang@intel.com>; dev@dpdk.org
> Cc: Wang, Zhihong <zhihong.wang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versions
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> <snip>
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang
> <snip>
> > > +
> > > +Virtio PMD Versions
> > > +-------------------
> > > +
> > > +Virtio driver has 3 versions of rx functions and 2 versions of tx
> > > functions.
> >
> > In some places RX/TX is used and in some rx/tx. I would suggest the
> > uppercase versions throughout.
> >
>=20
> In the commit logs, the only valid contractions allowed by the check-git-
> log.sh script are Rx and Tx
>=20
> bad=3D$(echo "$headlines" | grep -E --color=3Dalways \
>         -e '\<(rx|tx|RX|TX)\>' \
> 	 ....
>=20
> I would therefore suggest we follow the same rules for the docs for
> consistency.

Hi,

I don't mind what it is once we have consistency, so Rx/Tx is fine. Zhihong=
,=20
please note.

John