From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 10119C352 for ; Wed, 15 Jun 2016 11:05:39 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 15 Jun 2016 02:05:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,475,1459839600"; d="scan'208";a="122218706" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 15 Jun 2016 02:05:38 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Jun 2016 10:05:37 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by irsmsx112.ger.corp.intel.com ([169.254.1.18]) with mapi id 14.03.0248.002; Wed, 15 Jun 2016 10:05:37 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "Pattan, Reshma" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support Thread-Index: AQHRxiCja06+m2RnbUmvMcAnDs8PXZ/pWZqAgADf2OA= Date: Wed, 15 Jun 2016 09:05:36 +0000 Message-ID: References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-6-git-send-email-reshma.pattan@intel.com> <3000552.2jYBPTLpa9@xps13> In-Reply-To: <3000552.2jYBPTLpa9@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmYzZTliYmItYmVmMC00M2Q1LWI3MmUtZDEyMzRmNGI2NmNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZ0aFQ0QVo2c2RnTlRHUzhjc3ErTzBYM0xXR3FiY2NmUGVpVFBpbUNPSlU9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 09:05:40 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support >=20 > 2016-06-14 10:38, Reshma Pattan: > > The new librte_pdump library is added for packet capturing support. > > >=20 > And more importantly, we need a doc in the prog guide. >=20 Hi Thomas, The Programmers Guide update is in another part of the patchset. Can we get= some clarification on the requirements for documentation within patchset? Should all documentation related to a feature be in the patch for the featu= re? From your recent comments on patches it looks like that is the way you = prefer it. That is fine but there is some confusion because it seems that w= asn't always a requirement in the past so it would be best to clarify, and = preferably document this. Also, it makes it a bit harder for the documentation maintainer (me in this= case) to see doc changes within patches and to ack just the doc part. From= a documentation maintainer point of view it would be best to have any, non= -trivial, doc changes in a separate patch. John