From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id BA0DECB52
 for <dev@dpdk.org>; Wed, 15 Jun 2016 17:44:15 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 15 Jun 2016 08:44:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,476,1459839600"; d="scan'208";a="1002569455"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga002.fm.intel.com with ESMTP; 15 Jun 2016 08:44:14 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.155]) with mapi id 14.03.0248.002;
 Wed, 15 Jun 2016 16:44:13 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet
 capturing support
Thread-Index: AQHRxujtofRWXHohRkyA3HhrgvE6lJ/qoxFw
Date: Wed, 15 Jun 2016 15:44:13 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE202581CC5@IRSMSX103.ger.corp.intel.com>
References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com>
 <3000552.2jYBPTLpa9@xps13>
 <B27915DBBA3421428155699D51E4CFE202581789@IRSMSX103.ger.corp.intel.com>
 <10727658.5TGes6emps@xps13>
In-Reply-To: <10727658.5TGes6emps@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGNkN2QxOTEtZWYyMC00NTU4LThlYjQtYTNlNzdmYWViZDA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJRV2RmYzljREJxT0o3bGJtTDJKRnl1cWc0N1NHTCt4aHd3SkxcLzZ3MjV6Zz0ifQ==
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet
 capturing support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2016 15:44:16 -0000


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, June 15, 2016 10:33 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet
> capturing support
>
> > Also, it makes it a bit harder for the documentation maintainer (me in
> this case) to see doc changes within patches and to ack just the doc part=
.
> From a documentation maintainer point of view it would be best to have
> any, non-trivial, doc changes in a separate patch.
>=20
> I understand your concern.
> But you cannot assume every doc changes will be properly highlighted in
> the headline. I think you need to filter patches based on a content
> pattern:
> 	+++ b/doc/guides/

Hi Thomas,

That still leaves the issue of not being able to ack the doc part of the pa=
tch
separately from the rest of the patch.

John