From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2E9EFC55C for ; Sat, 25 Jun 2016 00:51:44 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 24 Jun 2016 15:51:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,523,1459839600"; d="scan'208";a="724680016" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jun 2016 15:51:42 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by IRSMSX109.ger.corp.intel.com ([169.254.13.193]) with mapi id 14.03.0248.002; Fri, 24 Jun 2016 23:51:41 +0100 From: "Mcnamara, John" To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring size Thread-Index: AQHRzjakDVBmnnGbZUu88oqGm036gp/5OXNg Date: Fri, 24 Jun 2016 22:51:41 +0000 Message-ID: References: <1466776473-30883-1-git-send-email-reshma.pattan@intel.com> <1466786183-3772-1-git-send-email-reshma.pattan@intel.com> <1466786183-3772-6-git-send-email-reshma.pattan@intel.com> In-Reply-To: <1466786183-3772-6-git-send-email-reshma.pattan@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUyMDk1YjYtYmQzYi00YmE2LWE4NmQtY2ExYmI3YWM2ZWU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFlbTY5aXpYVDBRWlZ4TTlNZFZSeW5MWDJLNU10aDI2aHFrR1Y2K2NudmM9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 22:51:44 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, June 24, 2016 5:36 PM > To: dev@dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring > size >=20 > ring_size value is wrongly type casted to uint16_t. > It should be type casted to uint32_t, as maximum ring size is 28bit long. > Wrong type cast wrapping around the ring size values bigger than 65535. >=20 > Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") >=20 > Signed-off-by: Reshma Pattan Acked-by: John McNamara