From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2AB8B2C01 for ; Tue, 19 Jul 2016 15:57:59 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 19 Jul 2016 06:57:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,389,1464678000"; d="scan'208";a="141878537" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga004.fm.intel.com with ESMTP; 19 Jul 2016 06:57:56 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX106.ger.corp.intel.com ([169.254.8.145]) with mapi id 14.03.0248.002; Tue, 19 Jul 2016 14:57:12 +0100 From: "Mcnamara, John" To: Yuanhan Liu , "dev@dpdk.org" CC: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature Thread-Index: AQHR4XQUT1sKdDqTfUGGBfD7rPpCH6Afx56g Date: Tue, 19 Jul 2016 13:57:11 +0000 Message-ID: References: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTViOWUyNzctMWZiMy00MTZjLTk2YWItZmFjMzVmYjA0MmJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik8rdzNsMlB1UURjbkpzOTNhVFwveWFIYnU1ajhcL0lWK0tpYTY4V3NzVURRbz0ifQ== x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 13:57:59 -0000 > - Note: the "reconnect" feature requires **QEMU v2.7** (or above). > + .. Note:: > + * The "reconnect" feature requires **QEMU v2.7** (or above). > + > + * The vhost supported features must be exactly the same before and > + after the restart. For example, if TSO is disabled and then > enabled, > + nothing will work and issues undefined might happen. s/ issues undefined / undefined issues / Apart from that: Acked-by: John McNamara