From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Breen, Eoin" <eoin.breen@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Breen, Eoin" <eoin.breen@intel.com>
Subject: Re: [dpdk-dev] [PATCH] tools: add crypto device details
Date: Thu, 25 Aug 2016 10:32:01 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2025D48B3@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1472119499-70304-1-git-send-email-eoin.breen@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Eoin Breen
> Sent: Thursday, August 25, 2016 11:05 AM
> To: Jain, Deepak K <deepak.k.jain@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Cc: dev@dpdk.org; Breen, Eoin <eoin.breen@intel.com>
> Subject: [dpdk-dev] [PATCH] tools: add crypto device details
>
> Adding the support to bind/unbind crypto devices with dpdk-devbind.py
> script, as now it is not restricted to network devices anymore.
>
Hi Eoin,
There are a couple of small pep8 issues to fix:
$ pep8 tools/dpdk-devbind.py
tools/dpdk-devbind.py:302:1: E302 expected 2 blank lines, found 1
tools/dpdk-devbind.py:653:33: E261 at least two spaces before inline comment
See: http://dpdk.org/doc/guides/contributing/coding_style.html#python-code
John
next prev parent reply other threads:[~2016-08-25 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 10:04 Eoin Breen
2016-08-25 10:32 ` Mcnamara, John [this message]
2016-08-25 13:52 ` [dpdk-dev] [PATCH v2] " Eoin Breen
2016-08-25 20:31 ` Jain, Deepak K
2016-09-13 22:50 ` De Lara Guarch, Pablo
2016-09-15 23:57 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2016-09-20 0:05 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2016-09-21 10:04 ` Jain, Deepak K
2016-09-21 18:56 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2025D48B3@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=eoin.breen@intel.com \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).