From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B83D4902 for ; Fri, 9 Sep 2016 16:33:42 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP; 09 Sep 2016 07:33:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,305,1470726000"; d="scan'208";a="6842352" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga004.jf.intel.com with ESMTP; 09 Sep 2016 07:33:40 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX108.ger.corp.intel.com ([169.254.11.71]) with mapi id 14.03.0248.002; Fri, 9 Sep 2016 15:33:38 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "Yigit, Ferruh" CC: Stephen Hemminger , zhouyangchao , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash Thread-Index: AQHSCpdig1mxxEaoJ0236FAN5Bi496BxLAGw Date: Fri, 9 Sep 2016 14:33:37 +0000 Message-ID: References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> <20160908094442.4dfa5b01@xeon-e3> <05b14d74-b168-69b2-b107-124ee951dc27@intel.com> <2019611.627KgLZ47A@xps13> In-Reply-To: <2019611.627KgLZ47A@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTg3ZjFlOTgtY2M2YS00MDlmLWIyY2ItZTgwNDQ1NWM0ZWQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJIQVNhWlBaMCt1UUFVOGdrYWpHSjBPUDJ0WjFxQlVOK05KUnF6UWNDM0kwPSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 14:33:43 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, September 9, 2016 1:40 PM > To: Yigit, Ferruh > Cc: Stephen Hemminger ; zhouyangchao > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device > could cause a kernel crash >=20 > 2016-09-08 18:15, Ferruh Yigit: > > On 9/8/2016 5:44 PM, Stephen Hemminger wrote: > > > > ... > > > > > But then again the whole KNI driver fails completely when running > > > kernel style check. > > > > > > > Yes, it generates lots of warnings. > > I can fix them (excluding ethtool/*), that wouldn't take much time but > > how syntax only patches welcomed? Another concern is it trashes git > blame. >=20 > You ask a question and give the answer ;) I think it depends just on the > balance of the pros/cons - to be evaluated. Hi, I think in general we would prefer to avoid any large scale code beautifica= tion since, as pointed out, it breaks the option to git blame. However, in the case of the KNI code the main author in git is "Intel" so g= it blame doesn't tell you a lot. Also, Ferruh is the maintainer, has made m= ost of the recent changes, and is actively maintaining/improving it. So I t= hink if the syntax fix came from him it would be okay. At least it would al= low us to apply the checkpatch checks. John