From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7B26C2B8C for ; Mon, 26 Sep 2016 22:17:05 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 26 Sep 2016 13:17:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,401,1470726000"; d="scan'208";a="1056901369" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 26 Sep 2016 13:17:02 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by IRSMSX102.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002; Mon, 26 Sep 2016 21:17:01 +0100 From: "Mcnamara, John" To: Kamil Rytarowski , "dev@dpdk.org" CC: "maciej.czekaj@caviumnetworks.com" , "zyta.szpak@semihalf.com" , "slawomir.rosek@semihalf.com" , "rad@semihalf.com" , "jerin.jacob@caviumnetworks.com" , Kamil Rytarowski Thread-Topic: [dpdk-dev] [PATCH 13/13] net/thunderx: document secondary queue set support Thread-Index: AQHR/7sL1iLV47vmdkOWJNsvnZKyXqCMYwrQ Date: Mon, 26 Sep 2016 20:17:00 +0000 Message-ID: References: <1472230448-17490-1-git-send-email-krytarowski@caviumnetworks.com> <1472230448-17490-14-git-send-email-krytarowski@caviumnetworks.com> In-Reply-To: <1472230448-17490-14-git-send-email-krytarowski@caviumnetworks.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjRjNjJhMzAtZWViNS00MWJjLWJkNzItNWI5NGFmZTZiMWI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Imp6MW1OejJPdTBTMExDM1Bzb3FBTkZHVGVGOXB4aENaWnpnNm1zSUljc1U9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 13/13] net/thunderx: document secondary queue set support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 20:17:06 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kamil Rytarowski > Sent: Friday, August 26, 2016 5:54 PM > To: dev@dpdk.org > Cc: maciej.czekaj@caviumnetworks.com; zyta.szpak@semihalf.com; > slawomir.rosek@semihalf.com; rad@semihalf.com; > jerin.jacob@caviumnetworks.com; Kamil Rytarowski > > Subject: [dpdk-dev] [PATCH 13/13] net/thunderx: document secondary queue > set support >=20 There are some whitespace errors in the docs: Applying patch #15435 using 'git am' Description: [dpdk-dev,13/13] net/thunderx: document secondary queue se= t support Applying: net/thunderx: document secondary queue set support .git/rebase-apply/patch:70: trailing whitespace. =20 .git/rebase-apply/patch:74: trailing whitespace. =20 .git/rebase-apply/patch:98: trailing whitespace. Some other minor comments below. >=20 > Supported ThunderX SoCs > ----------------------- > @@ -322,6 +323,112 @@ This section provides instructions to configure SR- > IOV with Linux OS. > #. Refer to section :ref:`Running testpmd ` fo= r > instruction > how to launch ``testpmd`` application. >=20 > +Multiple Queue Set per DPDK port configuration > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +There are two types of VFs: > + > +- Primary VF > +- Secondary VF > + > +Each port consist of a primary VF and n secondary VF(s). Each VF provide= s s/consist/consists/ > 8 Tx/Rx queues to a port. > +In case port is configured to use more than 8 queues, then it requires > +one (or more) secondary VF. Each secondary VF adds additional 8 queues t= o > the queue set. There are a few missing definite and indefinite articles missing in the tex= t. > + > +During PMD driver initialization, the primary VF's are enumerated by > +checking the specific flag (see sqs message in DPDK boot log - sqs > indicates secondary queue set). > +They are at the beginning of VF list (the remain ones are secondary > VF's). > + > +The primary VFs are used as master queue sets. Secondary VFs provid s/provid/provide/ > +additional queue sets for primary ones. If a port is configured for > +more then > +8 queues than it will request for additional queues from secondary VFs. > + > +Secondary VFs cannot be shared between primary VFs. > + > +Primary VFs are present on the beginning of the 'Network devices using > +kernel driver' list, secondary VFs are on the remaining on the remaining > part of the list. > + > + .. note:: > + This note and the following one are indented too far. They should be aligne= d with the margin. > ... > +Example device binding > +~~~~~~~~~~~~~~~~~~~~~~ > + > +If a system has three interfaces, a total of 18 VF devices will be > +created on a non-NUMA machine. > + > + .. note:: > + > + NUMA systems have 12 VFs per port and non-NUMA 6 VFs per port. > + > + .. code-block:: console This note and code block are indented too far. They should be aligned with = the margin. > + > + # tools/dpdk-devbind.py --status > + > + Network devices using DPDK-compatible driver > + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > + > + Network devices using kernel driver > + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + 0000:01:10.0 'Device a026' if=3D drv=3Dthunder-BGX unused=3Dvfio- > pci,uio_pci_generic > + 0000:01:10.1 'Device a026' if=3D drv=3Dthunder-BGX unused=3Dvfio- > pci,uio_pci_generic > + 0002:01:00.0 'Device a01e' if=3D drv=3Dthunder-nic unused=3Dvfio- > pci,uio_pci_generic > + 0002:01:00.1 'Device 0011' if=3Deth0 drv=3Dthunder-nicvf unused=3D= vfio- > pci,uio_pci_generic > + 0002:01:00.2 'Device 0011' if=3Deth1 drv=3Dthunder-nicvf unused=3D= vfio- > pci,uio_pci_generic > + 0002:01:00.3 'Device 0011' if=3Deth2 drv=3Dthunder-nicvf unused=3D= vfio- > pci,uio_pci_generic > + 0002:01:00.4 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:00.5 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:00.6 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:00.7 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.0 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.1 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.2 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.3 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.4 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.5 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.6 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:01.7 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:02.0 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:02.1 'Device 0011' if=3D drv=3Dthunder-nicvf unused=3Dvfio= - > pci,uio_pci_generic > + 0002:01:02.2 'Device 0011' if=3D drv=3Dthunder-nicvf > + unused=3Dvfio-pci,uio_pci_generic > + > + Other network devices > + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + 0002:00:03.0 'Device a01f' unused=3Dvfio-pci,uio_pci_generic > + > + > +We want to bind two physical interfaces with 24 queues each device, we > +attach two primary VFs and four secondary queues. In our example we > choose two 10G interfaces eth1 (0002:01:00.2) and eth2 (0002:01:00.3). > +We will chose four secondary queue sets from the ending of the list > (0002:01:01.7-0002:01:02.2). s/chose/choose/ > + > + > +#. Bind two primary VFs to the ``vfio-pci`` driver: > + > + .. code-block:: console > + These code blocks are indented correctly. John. --=20