From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 55F3F3978 for ; Fri, 4 Nov 2016 14:28:49 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 04 Nov 2016 06:28:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,443,1473145200"; d="scan'208";a="1080620662" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 04 Nov 2016 06:28:47 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.190]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Fri, 4 Nov 2016 13:28:47 +0000 From: "Mcnamara, John" To: Yuanhan Liu , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] vhost: update comments Thread-Index: AQHSNLc5FDxZRk3ztEqoh/ylrns1VaDI1Few Date: Fri, 4 Nov 2016 13:28:45 +0000 Message-ID: References: <1478056501-9321-1-git-send-email-yuanhan.liu@linux.intel.com> <1478056501-9321-4-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1478056501-9321-4-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjBhZDI1ZTEtZGE0OC00ZmE4LWI5ZGEtZjI3ZGE3ZjYzM2U3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldjUk1rRHJWNWV0VVVkYW9CRlhKYTdzMkVRaVIyUk5reHNKVUZcL0lYcXc4PSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] vhost: update comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 13:28:50 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, November 2, 2016 3:15 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Yuanhan Liu > > Subject: [PATCH 3/3] vhost: update comments >=20 > vhost-cuse is removed, update corresponding comments that are still > referencing it. >=20 > Signed-off-by: Yuanhan Liu > > ... > > /* > - * Backend-specific cleanup. Defined by vhost-cuse and vhost-user. > + * Backend-specific cleanup. > + * > + * TODO: fix it; we have one backend now > */ > void vhost_backend_cleanup(struct virtio_net *dev); In general it is not a good idea to leave TODOs/Fixmes around unless they that a better explanation of why they are there. Apart from that: Acked-by: John McNamara