* [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment
@ 2016-11-14 2:15 Wei Zhao
2016-11-14 10:25 ` Mcnamara, John
0 siblings, 1 reply; 3+ messages in thread
From: Wei Zhao @ 2016-11-14 2:15 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, zhao wei
From: zhao wei <wei.zhao1@intel.com>
There is a redundant repetition mempool socket_id assignment in the
file rte_mempool.c in function rte_mempool_create_empty.The
statement "mp->socket_id = socket_id;"appear twice in line 821
and 824.One of them is redundant, so delete it.
Fixes: 85226f9c526b ("lib/librte_mempool: mempool:introduce
a function to create an empty pool")
Signed-off-by: zhao wei <wei.zhao1@intel.com>
---
lib/librte_mempool/rte_mempool.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index aa513b9..1c2aed8 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -818,7 +818,6 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
goto exit_unlock;
}
mp->mz = mz;
- mp->socket_id = socket_id;
mp->size = n;
mp->flags = flags;
mp->socket_id = socket_id;
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment
2016-11-14 2:15 [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment Wei Zhao
@ 2016-11-14 10:25 ` Mcnamara, John
2016-11-18 14:07 ` Olivier Matz
0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2016-11-14 10:25 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: olivier.matz, Zhao1, Wei
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Monday, November 14, 2016 2:16 AM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
> assignment
>
> From: zhao wei <wei.zhao1@intel.com>
>
> There is a redundant repetition mempool socket_id assignment in the file
> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
> >socket_id = socket_id;"appear twice in line 821 and 824.One of them is
> redundant, so delete it.
>
> Fixes: 85226f9c526b ("lib/librte_mempool: mempool:introduce a function to
> create an empty pool")
>
> Signed-off-by: zhao wei <wei.zhao1@intel.com>
Titles should generally start with a verb to indicate what is being done.
Something like:
lib/librte_mempool: remove redundant socket_id assignment
Apart from that.
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment
2016-11-14 10:25 ` Mcnamara, John
@ 2016-11-18 14:07 ` Olivier Matz
0 siblings, 0 replies; 3+ messages in thread
From: Olivier Matz @ 2016-11-18 14:07 UTC (permalink / raw)
To: Mcnamara, John, Zhao1, Wei, dev
Hi Wei,
On 11/14/2016 11:25 AM, Mcnamara, John wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
>> Sent: Monday, November 14, 2016 2:16 AM
>> To: dev@dpdk.org
>> Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
>> assignment
>>
>> From: zhao wei <wei.zhao1@intel.com>
>>
>> There is a redundant repetition mempool socket_id assignment in the file
>> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
>>> socket_id = socket_id;"appear twice in line 821 and 824.One of them is
>> redundant, so delete it.
>>
>> Fixes: 85226f9c526b ("lib/librte_mempool: mempool:introduce a function to
>> create an empty pool")
>>
>> Signed-off-by: zhao wei <wei.zhao1@intel.com>
>
> Titles should generally start with a verb to indicate what is being done.
> Something like:
>
> lib/librte_mempool: remove redundant socket_id assignment
>
> Apart from that.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
I would even say:
mempool: remove redundant socket_id assignment
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-18 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 2:15 [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment Wei Zhao
2016-11-14 10:25 ` Mcnamara, John
2016-11-18 14:07 ` Olivier Matz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).