From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 822AF2BD6
 for <dev@dpdk.org>; Mon, 14 Nov 2016 11:25:29 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 14 Nov 2016 02:25:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,638,1473145200"; 
   d="scan'208";a="3851700"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga002.jf.intel.com with ESMTP; 14 Nov 2016 02:25:27 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.190]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0248.002;
 Mon, 14 Nov 2016 10:25:26 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Zhao1, Wei"
 <wei.zhao1@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of
 socket_id	assignment
Thread-Index: AQHSPh2K8TounpvOg022uT2FoHZdNKDYRe1A
Date: Mon, 14 Nov 2016 10:25:26 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20264E206@IRSMSX103.ger.corp.intel.com>
References: <1479089737-1966-1-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1479089737-1966-1-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBiNGU2YWMtMWY5MC00MmI2LTg3MDUtNjQ0NWE1NTc1ZDEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldJZDVDRFY2RUlvWVlkZDNjcUdUMmEwdUJhcGRSYW1mTkRzbDZcL3VPVkNrPSJ9
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of
	socket_id	assignment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Nov 2016 10:25:30 -0000


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Monday, November 14, 2016 2:16 AM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
> assignment
>=20
> From: zhao wei <wei.zhao1@intel.com>
>=20
> There is a redundant repetition mempool socket_id assignment in the file
> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
> >socket_id =3D socket_id;"appear twice in line 821 and 824.One of them is
> redundant, so delete it.
>=20
> Fixes: 85226f9c526b ("lib/librte_mempool:  mempool:introduce a function t=
o
> create an empty pool")
>=20
> Signed-off-by: zhao wei <wei.zhao1@intel.com>

Titles should generally start with a verb to indicate what is being done.
Something like:

    lib/librte_mempool: remove redundant socket_id assignment

Apart from that.=20

Acked-by: John McNamara <john.mcnamara@intel.com>