From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] nfp: add doc about supported features
Date: Tue, 6 Dec 2016 12:46:57 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20266F604@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <3133b0c5-672d-de7d-1690-815c7603e581@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, December 6, 2016 12:08 PM
> To: Alejandro Lucero <alejandro.lucero@netronome.com>; dev@dpdk.org;
> Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] nfp: add doc about supported features
>
> On 12/2/2016 8:17 AM, Alejandro Lucero wrote:
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> > doc/guides/nics/features/nfp.ini | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/nfp.ini
> b/doc/guides/nics/features/nfp.ini
> > index d967151..dd78233 100644
> > --- a/doc/guides/nics/features/nfp.ini
> > +++ b/doc/guides/nics/features/nfp.ini
> > @@ -4,3 +4,28 @@
> > ; Refer to default.ini for the full list of available PMD features.
> > ;
> > [Features]
> > +SR-IOV = Y
> > +Link status = Y
> > +Link status event = Y
> > +Rx interrupt = N
>
> Hi John,
>
> Do we support 'N'? Since this is the first 'N' in the table.
>
> I guess not having a value implies feature is not supported.
N or any other single letter is supported.
The nice thing about it is that it is explicitly NO rather than implicitly NO. However, if all the nics filled in the NOes then the table might be hard to read.
So, for consistency it is probably best to just let the unsupported features be blank.
next prev parent reply other threads:[~2016-12-06 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 8:17 Alejandro Lucero
2016-12-02 10:56 ` Mcnamara, John
2016-12-06 12:08 ` Ferruh Yigit
2016-12-06 12:46 ` Mcnamara, John [this message]
2016-12-06 14:51 ` Alejandro Lucero
2016-12-06 16:01 ` Ferruh Yigit
2016-12-09 10:00 ` Alejandro Lucero
2016-12-09 11:36 ` Ferruh Yigit
2016-12-16 17:29 ` Alejandro Lucero
2016-12-19 11:45 ` Ferruh Yigit
2016-12-19 11:58 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE20266F604@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).