From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] KNI broken again with 4.9 kernel
Date: Thu, 15 Dec 2016 12:01:06 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202685DB8@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20161214154049.698de2e8@xeon-e3>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, December 14, 2016 11:41 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] KNI broken again with 4.9 kernel
>
> /build/lib/librte_eal/linuxapp/kni/igb_main.c:2317:21: error:
> initialization from incompatible pointer type [-Werror=incompatible-
> pointer-types]
> .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
> ^~~~~~~~~~~~~~~~~~~
>
> I am sure Ferruh Yigit will fix it.
>
> Which raises a couple of questions:
> 1. Why is DPDK still keeping KNI support for Intel specific ethtool
> functionality.
> This always breaks, is code bloat, and means a 3rd copy of base code
> (Linux, DPDK PMD, + KNI)
>
> 2. Why is KNI not upstream?
> If not acceptable due to security or supportablity then why does it
> still exist?
>
> 3. If not upstream, then maintainer should track upstream kernel changes
> and fix DPDK before
> kernel is released. The ABI is normally set early in the rc cycle
> weeks before release.
Hi Stephen,
On point 2: The feedback we have always received is that the KNI code isn't upstreamable. Do you think there is an upstream path?
> If not acceptable due to security or supportablity then why does it
> still exist?
The most commonly expressed reason when we have asked this question in the past (and we did again at Userspace a few months ago) is that the people who use it want the performance.
On point 3: We do have an internal continuous integration system that runs nightly compiles of DPDK against the latest kernel and flags any issues.
John
next prev parent reply other threads:[~2016-12-15 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 23:40 Stephen Hemminger
2016-12-15 10:25 ` Ferruh Yigit
2016-12-15 11:53 ` [dpdk-dev] KNI Questions Ferruh Yigit
2016-12-15 17:16 ` Stephen Hemminger
2016-12-15 17:26 ` John Fastabend
2016-12-15 12:01 ` Mcnamara, John [this message]
2016-12-15 12:55 ` [dpdk-dev] KNI broken again with 4.9 kernel Jay Rolette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE202685DB8@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).