From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4152710A7 for ; Thu, 15 Dec 2016 13:01:08 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 15 Dec 2016 04:01:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,351,1477983600"; d="scan'208";a="42657137" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga005.jf.intel.com with ESMTP; 15 Dec 2016 04:01:07 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.124]) by irsmsx110.ger.corp.intel.com ([169.254.15.45]) with mapi id 14.03.0248.002; Thu, 15 Dec 2016 12:01:06 +0000 From: "Mcnamara, John" To: Stephen Hemminger , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [dpdk-dev] KNI broken again with 4.9 kernel Thread-Index: AQHSVmOje1Y5L+zK5ESeb4hsE6ZBQaEI5qJA Date: Thu, 15 Dec 2016 12:01:06 +0000 Message-ID: References: <20161214154049.698de2e8@xeon-e3> In-Reply-To: <20161214154049.698de2e8@xeon-e3> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWU0YWY4ZjItODVkMS00MTNlLWI4ZmYtZGY1Y2U5OTEyMTFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpsRWVpMUpCOG1VYWw4bWpRa2oyaEhjOTZcL0ZZKzZ6Uk93SjVcL3NRWUF5TT0ifQ== x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] KNI broken again with 4.9 kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 12:01:09 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, December 14, 2016 11:41 PM > To: dev@dpdk.org > Subject: [dpdk-dev] KNI broken again with 4.9 kernel >=20 > /build/lib/librte_eal/linuxapp/kni/igb_main.c:2317:21: error: > initialization from incompatible pointer type [-Werror=3Dincompatible- > pointer-types] > .ndo_set_vf_vlan =3D igb_ndo_set_vf_vlan, > ^~~~~~~~~~~~~~~~~~~ >=20 > I am sure Ferruh Yigit will fix it. >=20 > Which raises a couple of questions: > 1. Why is DPDK still keeping KNI support for Intel specific ethtool > functionality. > This always breaks, is code bloat, and means a 3rd copy of base code > (Linux, DPDK PMD, + KNI) >=20 > 2. Why is KNI not upstream? > If not acceptable due to security or supportablity then why does it > still exist? >=20 > 3. If not upstream, then maintainer should track upstream kernel changes > and fix DPDK before > kernel is released. The ABI is normally set early in the rc cycle > weeks before release. Hi Stephen, On point 2: The feedback we have always received is that the KNI code isn't= upstreamable. Do you think there is an upstream path?=20 > If not acceptable due to security or supportablity then why does it > still exist? The most commonly expressed reason when we have asked this question in the = past (and we did again at Userspace a few months ago) is that the people wh= o use it want the performance. On point 3: We do have an internal continuous integration system that runs = nightly compiles of DPDK against the latest kernel and flags any issues. John