From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2EF4B2B9F for ; Sun, 18 Dec 2016 21:50:39 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 18 Dec 2016 12:50:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,371,1477983600"; d="scan'208";a="1101166540" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 18 Dec 2016 12:50:29 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.124]) by IRSMSX154.ger.corp.intel.com ([169.254.12.128]) with mapi id 14.03.0248.002; Sun, 18 Dec 2016 20:50:28 +0000 From: "Mcnamara, John" To: Baruch Siach CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: fix required tools list layout Thread-Index: AQHSVShDKyivGUjOzUWxbO+D6DvmraEJHhfAgAT8iACAABl2IA== Date: Sun, 18 Dec 2016 20:50:27 +0000 Message-ID: References: <819ec07b51126e7877503b95fa30d7fd8da3a42a.1481623418.git.baruch@tkos.co.il> <20161218191100.nzgn2w7465qnk26v@tarshish> In-Reply-To: <20161218191100.nzgn2w7465qnk26v@tarshish> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmMwZDU5ZDAtZmEwNS00MjE5LWJjZjUtNmI0NGM1ZTgxZWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZOZ3ljTHlFdzhcL3hLSXRaUFhNd0ZFWmdSOWtuTit2VDZEQmR0eU1ncGxjPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix required tools list layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 20:50:40 -0000 > -----Original Message----- > From: Baruch Siach [mailto:baruch@tkos.co.il] > Sent: Sunday, December 18, 2016 7:11 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: fix required tools list layout >=20 > Hi John, >=20 > On Thu, Dec 15, 2016 at 03:09:32PM +0000, Mcnamara, John wrote: > > > -----Original Message----- > > > From: Baruch Siach [mailto:baruch at tkos.co.il] > > > Sent: Tuesday, December 13, 2016 10:04 AM > > > To: dev at dpdk.org > > > Cc: Mcnamara, John ; David Marchand > > > ; Baruch Siach > > > Subject: [PATCH] doc: fix required tools list layout > > > > > > The Python requirement should appear in the bullet list. > > > > > > Signed-off-by: Baruch Siach > > > --- > > > doc/guides/linux_gsg/sys_reqs.rst | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst > > > b/doc/guides/linux_gsg/sys_reqs.rst > > > index 3d743421595a..621cc9ddaef6 100644 > > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > > @@ -84,9 +84,7 @@ Compilation of the DPDK > > > x86_x32 ABI is currently supported with distribution packages > > > only on Ubuntu > > > higher than 13.10 or recent Debian distribution. The only > > > supported compiler is gcc 4.9+. > > > > > > -.. note:: > > > - > > > - Python, version 2.6 or 2.7, to use various helper scripts > included in > > > the DPDK package. > > > +* Python, version 2.6 or 2.7, to use various helper scripts > included in > > > the DPDK package. > > > > In addition to this change the note on the previous item should be > > indented to the level of the bullet item. It is probably worth making > > that change at the same time. >=20 > All items are equally aligned as far as I can see. The 32bit on 64bit > requirement bullets are sub-items of the previous item. Am I missing > anything? Hi Baruch, The note should be indented to the level of the first level bullet item tex= t rather than the margin since it is a note on that particular item and not a genera= l note. Like this: * Additional packages required for 32-bit compilation on 64-bit syste= ms are: * glibc.i686, libgcc.i686, libstdc++.i686 and glibc-devel.i686 for = Intel i686/x86_64; * glibc.ppc64, libgcc.ppc64, libstdc++.ppc64 and glibc-devel.ppc64 = for IBM ppc_64; .. note:: x86_x32 ABI is currently supported with distribution packages on= ly on Ubuntu higher than 13.10 or recent Debian distribution. The only suppor= ted compiler is gcc 4.9+. If you generate the html before and after you will see the difference. >=20 > > Also, the Python version should probably say 2.7+ and 3.2+ if this > > patch is > > accepted: > > > > http://dpdk.org/dev/patchwork/patch/17775/ > > > > However, since that change hasn't been acked/merged yet you can leave > > that part of your patch as it is and I'll fix the version numbers in > > the other patch. >=20 > Note that your updated patch[1] conflicts with this one. >=20 Yes. :-) It also conflicts with Thomas' patch to move the directories. I'll rebase b= ased on whatever order the patches are applied in. John