From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] doc: update release notes for 17.02
Date: Tue, 14 Feb 2017 16:22:35 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2026CC254@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1551253.KADGnDBYIu@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, February 14, 2017 3:51 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] doc: update release notes for 17.02
>
> 2017-02-14 15:32, John McNamara:
> > -Resolved Issues
> > ----------------
> > -
> > -.. This section should contain bug fixes added to the relevant
> sections. Sample format:
> > -
> > - * **code/section Fixed issue in the past tense with a full stop.**
> > -
> > - Add a short 1-2 sentence description of the resolved issue in the
> past tense.
> > - The title should contain the code/lib section like a commit
> message.
> > - Add the entries in alphabetic order in the relevant sections
> below.
> > -
> > - This section is a comment. do not overwrite or remove it.
> > - Also, make sure to start the actual text at the margin.
> > - =========================================================
> > -
> > -
> > -EAL
> > -~~~
> > -
> >
> > Drivers
> > ~~~~~~~
> >
> > * **net/virtio: Fixed multiple process support.**
> >
> > - Fixed few regressions introduced in recent releases that break the
> > virtio
> > + Fixed a few regressions introduced in recent releases that break
> > + the virtio
> > multiple process support.
> >
> >
> > -Libraries
> > -~~~~~~~~~
> > -
> > -
> > Examples
> > ~~~~~~~~
> >
> > * **examples/ethtool: Fixed crash with non-PCI devices.**
> >
> > - Querying a non-PCI device was dereferencing non-existent PCI data
> > - resulting in a segmentation fault.
> > + Fixed issue where querying a non-PCI device was dereferencing
> > + non-existent PCI data resulting in a segmentation fault.
>
> It looks strange to remove the "Resolved Issues" heading while keeping
> content.
> I think we could totally remove them as most of the fixes are not
> documented here anyway.
You are right. That was a mistake on my side, I meant to leave the heading.
However, now that you mention it, it doesn't look good that we have a
"Resolved Issues" section with just 2 fixes. I don't think they capture
the range of fixes in this release. Maybe we need to be more disciplined
with including information in the Release Notes when non-trivial fixes are
submitted.
In this case I'll put back in the "Resolved Issues" heading and submit a v2.
John
next prev parent reply other threads:[~2017-02-14 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:32 John McNamara
2017-02-14 15:51 ` Thomas Monjalon
2017-02-14 16:22 ` Mcnamara, John [this message]
2017-02-14 16:26 ` [dpdk-dev] [PATCH v2] " John McNamara
2017-02-14 20:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2026CC254@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).