From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C5CED108A for ; Mon, 6 Mar 2017 14:42:52 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2017 05:42:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,253,1484035200"; d="scan'208";a="73278252" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga006.fm.intel.com with ESMTP; 06 Mar 2017 05:42:51 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by irsmsx110.ger.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0248.002; Mon, 6 Mar 2017 13:42:49 +0000 From: "Mcnamara, John" To: Ravi Kerur , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [v4 3/3] EM config file read option. Thread-Index: AQHSleluMX/g1dHNj0a59zjGgph+LKGH0xqA Date: Mon, 6 Mar 2017 13:42:49 +0000 Message-ID: References: <1488743225-25750-1-git-send-email-rkerur@gmail.com> <1488743225-25750-4-git-send-email-rkerur@gmail.com> In-Reply-To: <1488743225-25750-4-git-send-email-rkerur@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IyOTA5YmUtOWM1Ny00OTM2LTk2OWQtZDg4ZWFkNzgwMGMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhPT2VOSGJSeE1xREtTcFpTd1lRSFBQRFp1NXhFNFBLcWRqM3ptUFV3V1E9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v4 3/3] EM config file read option. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 13:42:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > Sent: Sunday, March 5, 2017 7:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; Ravi Kerur > Subject: [dpdk-dev] [v4 3/3] EM config file read option. >=20 > v4: > > No changes. >=20 > v3: > > Fix additional checkpatch coding style issues. >=20 > v2: > > Fix checkpatch warnings. >=20 > v1: > > Remove static array configuration of Dest IP,Src IP, Dest > port, Src port, Proto and IF_OUT for EM and EM6 config. > > Add reading configuration from a file. > > Format of configuration file is as follows > #EM route entries, > #Dest-IP Src-IP Dest-port Src-port Proto IF_OUT > E101.0.0.0 100.10.0.0 101 11 0x06 0 > E201.0.0.0 200.20.0.0 102 12 0x06 1 > E111.0.0.0 211.30.0.0 101 11 0x06 2 > ... >=20 > #EM6 route entries > #Dest-IP Src-IP Dest-port Src-port Proto IF_OUT > Efe80:0000:0000:0000:021e:67ff:fe00:0000 > fe80:0000:0000:0000:021b:21ff:fe91:3805 101 11 0x06 0 > Efe90:0000:0000:0000:021e:67ff:fe00:0000 > fe90:0000:0000:0000:021b:21ff:fe91:3805 102 12 0x06 1 > ... Hi Ravi, Just a note on the structure of the commit message for this and the other patches. The first thing to do if you are new to contributing to DPDK is to have a read through the guidelines on "Contributing Code to DPDK": http://dpdk.org/doc/guides/contributing/patches.html In particular the subject line should contain the component that is being modified. Something like: examples/l3fwd: add config file support for exact match Do a git log examples/l3fwd to see some other examples and have a look at the following "Commit Messages: Subject Line" section of the above guidelin= es http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-su= bject-line The body of the message should contain a short description of what you are = changing, at a high level, and why you are changing it. See also: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-bo= dy The version information in your commit message is good but that should be i= ncluded after the --- line so that it is part of the patch but not part of the comm= it message. John.