DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd
Date: Thu, 9 Mar 2017 10:37:23 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2332567C1@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <CAFb4SLAugjVxwskxE1duYo9PkOuBOeUhunXGxZejmoHT1W5Fmg@mail.gmail.com>



> From: Ravi Kerur [mailto:rkerur@gmail.com] 
> Sent: Wednesday, March 8, 2017 9:51 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd


> Kindly let me know new 'v5' patch follows dpdk guidelines?


Hi Ravi,

In general the commit messages don't meet the guidelines, so it is 
probably worth reading through the guidelines again:

   http://dpdk.org/doc/guides/contributing/patches.html

In particular have a look at the sections on the "subject line" and the
"message body".

I'll make some other comments to your patches to help you along.

Thanks,

John

  reply	other threads:[~2017-03-09 10:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-05 19:47 Ravi Kerur
2017-03-05 19:47 ` [dpdk-dev] [v4 1/3] Merge l3fwd-acl and l3fwd code Ravi Kerur
2017-03-08 21:32   ` [dpdk-dev] [PATCH v5 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Ravi Kerur
2017-03-08 21:32     ` [dpdk-dev] [PATCH v5 1/3] " Ravi Kerur
2017-03-09 10:42       ` Mcnamara, John
2017-03-10 20:58       ` [dpdk-dev] [PATCH v6 0/3] " Ravi Kerur
2017-03-10 20:58         ` [dpdk-dev] [PATCH v6 1/3] " Ravi Kerur
2017-03-10 20:58         ` [dpdk-dev] [PATCH v6 2/3] examples/l3fwd: add config file support for lpm Ravi Kerur
2017-03-10 20:58         ` [dpdk-dev] [PATCH v6 3/3] examples/l3fwd: add config file support for exact Ravi Kerur
2017-06-04 11:14         ` [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Thomas Monjalon
2019-01-23 16:32         ` Ferruh Yigit
2019-01-23 17:10           ` Thomas Monjalon
2019-01-23 17:20             ` Ananyev, Konstantin
2019-01-23 17:26               ` Thomas Monjalon
2019-01-23 19:36                 ` Ferruh Yigit
2019-01-23 20:27                   ` Thomas Monjalon
2019-01-24  9:14               ` Rami Rosen
2017-03-08 21:32     ` [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: add config file support for LPM Ravi Kerur
2017-03-09 10:43       ` Mcnamara, John
2017-03-08 21:32     ` [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM Ravi Kerur
2017-03-09 10:45       ` Mcnamara, John
2017-03-10  0:00         ` Ravi Kerur
2017-03-05 19:47 ` [dpdk-dev] [v4 2/3] LPM config file read option Ravi Kerur
2017-03-06 13:57   ` Mcnamara, John
2017-03-06 14:10     ` Mcnamara, John
2017-03-05 19:47 ` [dpdk-dev] [v4 3/3] EM " Ravi Kerur
2017-03-06 13:42   ` Mcnamara, John
2017-03-06 13:33 ` [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd Mcnamara, John
2017-03-06 23:20   ` Ravi Kerur
2017-03-08 21:50     ` Ravi Kerur
2017-03-09 10:37       ` Mcnamara, John [this message]
2017-03-09 10:23     ` Mcnamara, John
2017-03-10  0:07       ` Ravi Kerur
2017-03-14 21:14         ` Ravi Kerur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE2332567C1@IRSMSX104.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=rkerur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).