From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 739C137B4 for ; Thu, 9 Mar 2017 11:42:17 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2017 02:42:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,268,1486454400"; d="scan'208";a="942370488" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 09 Mar 2017 02:42:15 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Thu, 9 Mar 2017 10:42:13 +0000 From: "Mcnamara, John" To: Ravi Kerur , "dev@dpdk.org" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Thread-Index: AQHSmFOmR/59gh2o2EidbD7xNwUbjKGMUfkA Date: Thu, 9 Mar 2017 10:42:13 +0000 Message-ID: References: <1488743225-25750-2-git-send-email-rkerur@gmail.com> <1489008729-28784-1-git-send-email-rkerur@gmail.com> <1489008729-28784-2-git-send-email-rkerur@gmail.com> In-Reply-To: <1489008729-28784-2-git-send-email-rkerur@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNjNjhhNGUtODAxNy00OGMyLTg5MjUtZDY5NmNmNzA3NmQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldSWHdxOU96OFNOR25vSCt1anFLekk3SklFK0trN21kYTVmRDQxRklwXC9vPSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 10:42:17 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > Sent: Wednesday, March 8, 2017 9:32 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce > Cc: Ravi Kerur > Subject: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code > into l3fwd >=20 > Merge l3fwd-acl code into l3fwd with '-A' cmdline option to run ACL. Hi Ravi, The subject line and commit message are okay. the only issue is that the version information should be after a triple dash line so that is doesn't appear in the commit message. The version information is intended for reviewers so that know what has changed since the last version. Just put the following before it: --- >=20 > v5: > > None. >=20 > v4: > > Initialize rss_hf to IP for LPM, EM and ACL. > > Update rss_hf with l4 in parse_args for ACL. > > Fix pending checkpatch code indentation warning. This applies to all the commit messages. John