From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7AEB7326C for ; Fri, 7 Apr 2017 11:23:36 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 07 Apr 2017 02:23:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,164,1488873600"; d="scan'208";a="70981982" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 07 Apr 2017 02:23:34 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by IRSMSX151.ger.corp.intel.com ([169.254.4.123]) with mapi id 14.03.0319.002; Fri, 7 Apr 2017 10:23:32 +0100 From: "Mcnamara, John" To: Shijith Thotton , Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD Thread-Index: AQHSrqr37pqfAhWvt0eOK0rvcCliZaG4mZiAgADThwCAADSXIA== Date: Fri, 7 Apr 2017 09:23:31 +0000 Message-ID: References: <1491059040-20647-1-git-send-email-shijith.thotton@caviumnetworks.com> <1491465117-11252-1-git-send-email-shijith.thotton@caviumnetworks.com> <1491465117-11252-2-git-send-email-shijith.thotton@caviumnetworks.com> <1840157.q6em4QXK2Z@xps13> <20170407070724.GA5581@localhost.localdomain> In-Reply-To: <20170407070724.GA5581@localhost.localdomain> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWIxZjJkMTEtOWY5Ny00Mzk5LTkxNDYtN2Y5MzQzZDBhYTNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldKaE93UzVaM0pURGVEVWhnMWNHOTVQcFV3YnRqVDJxTE9vOXo4Rk9jVFk9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 09:23:37 -0000 > -----Original Message----- > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > Sent: Friday, April 7, 2017 8:07 AM > To: Thomas Monjalon > Cc: Mcnamara, John ; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and > testing of PMD >=20 > On Thu, Apr 06, 2017 at 08:30:21PM +0200, Thomas Monjalon wrote: > > 2017-04-06 13:21, Shijith Thotton: > > > Add a section in NIC drivers documentation to explain compiling and > > > testing of a PMD. It also mentions about host setup, which is > > > required before running testpmd. > > > > > > Add label "testpmd_ug" to refer user guide. > > > > > > Signed-off-by: Shijith Thotton > > > > It is really good to factorize documentation. > > > > This doc is about testpmd in Linux > > and does not refer to FreeBSD. > > Do we assume to take Linux as the reference? >=20 > I can submit v2 with a subsection for running testpmd in FreeBSD. Hi, > I can submit v2 with a subsection for running testpmd in FreeBSD. I don't think that is necessary. You patch already calls out the Linux and FreeBSD Getting Started Guides. I think that is enough. @tmonjalo For me this new "Compiling and testing a PMD for a NIC" section is a way of avoiding duplicate sections in the NIC guides. I don't think it has to be a definitive guide to TestPMD. As and aside, I would like to do something similar with the sample app guides, i.e., have one section on compilation that the other app guides can refer to. I'll try to add that in the next release. So for me this patchset is okay as it is. John